Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Issue 2321243002: Milo: Add current builds to buildbot builder view (Closed)

Created:
4 years, 3 months ago by Ryan Tseng
Modified:
4 years, 1 month ago
Reviewers:
estaab, hinoka
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo: Add current builds to buildbot builder view BUG=468041 Committed: https://github.com/luci/luci-go/commit/c4cc5b18443f79c0b1e29600205e10efe9fda580

Patch Set 1 #

Patch Set 2 : Retrain #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : rebase fix #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -62 lines) Patch
M milo/appengine/buildbot/builder.go View 1 2 3 4 5 9 chunks +13 lines, -55 lines 0 comments Download
M milo/appengine/buildbot/master.go View 1 2 3 3 chunks +0 lines, -7 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuilder-Basic_Test_with_builds.html View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M milo/appengine/frontend/templates/buildbot/pages/builder.html View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 37 (28 generated)
Ryan Tseng
ptal, demo here: https://1103-e1a482a-tainted-hinoka-dot-luci-milo.appspot.com/buildbot/tryserver.chromium.android/linux_android_rel_ng/
4 years, 3 months ago (2016-09-08 22:02:22 UTC) #4
Ryan Tseng
Retrain
4 years, 3 months ago (2016-09-08 22:29:17 UTC) #7
Ryan Tseng
Rebase
4 years, 1 month ago (2016-10-27 01:34:16 UTC) #12
Ryan Tseng
Rebase
4 years, 1 month ago (2016-10-27 01:38:46 UTC) #17
estaab
The demo doesn't seem to work - I saw builds on the actual mater but ...
4 years, 1 month ago (2016-10-28 17:02:56 UTC) #26
hinoka
I probably deleted it, heres another one: https://1207-d5ac1f5-tainted-hinoka-dot-luci-milo.appspot.com/buildbot/tryserver.chromium.android/linux_android_rel_ng/
4 years, 1 month ago (2016-10-28 23:50:01 UTC) #28
estaab
lgtm
4 years, 1 month ago (2016-10-29 00:11:50 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321243002/100001
4 years, 1 month ago (2016-11-03 20:28:07 UTC) #35
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 21:16:15 UTC) #37
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://github.com/luci/luci-go/commit/c4cc5b18443f79c0b1e29600205e10efe9fda580

Powered by Google App Engine
This is Rietveld 408576698