A bunch more little cleanups in bot_update.

A bunch more little cleanups in bot_update.

R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d1d31d5d41b7d9fc79421b370c2ce9cea2551ad9

[hinoka, 2016-09-09 02:11:32]

lgtm

https://codereview.chromium.org/2321203003/diff/1/recipe_modules/bot_update/r...
File recipe_modules/bot_update/resources/bot_update.py (right):

https://codereview.chromium.org/2321203003/diff/1/recipe_modules/bot_update/r...
recipe_modules/bot_update/resources/bot_update.py:822:
parse.add_option('--root', dest='patch_root',
Delete?

https://codereview.chromium.org/2321203003/diff/1/recipe_modules/bot_update/r...
recipe_modules/bot_update/resources/bot_update.py:914: options.shallow =
(total_disk_space < SHALLOW_CLONE_THRESHOLD
or just "shallow = " (not sure if assigning to a non-existant attr works)

[agable, 2016-09-09 16:42:32]

lgtm % nit/question

https://codereview.chromium.org/2321203003/diff/20001/recipe_modules/bot_upda...
File recipe_modules/bot_update/resources/bot_update.py (right):

https://codereview.chromium.org/2321203003/diff/20001/recipe_modules/bot_upda...
recipe_modules/bot_update/resources/bot_update.py:876:
parse.error('--revision_mapping_file is required')
Can't you use required=True directly in argparse, rather than doing it out here?

[iannucci, 2016-09-09 22:28:18]

https://chromiumcodereview.appspot.com/2321203003/diff/1/recipe_modules/bot_u...
File recipe_modules/bot_update/resources/bot_update.py (right):

https://chromiumcodereview.appspot.com/2321203003/diff/1/recipe_modules/bot_u...
recipe_modules/bot_update/resources/bot_update.py:822:
parse.add_option('--root', dest='patch_root',
On 2016/09/09 at 02:11:32, hinoka wrote:
> Delete?

will delete in a followup. There's a version skew bug somewhere in the recipe
roller system which causes the old version of the bot_update module to use the
new version of the bot_update script. Not sure what causes it, but once the roll
is done, I'll delete this.

https://chromiumcodereview.appspot.com/2321203003/diff/1/recipe_modules/bot_u...
recipe_modules/bot_update/resources/bot_update.py:914: options.shallow =
(total_disk_space < SHALLOW_CLONE_THRESHOLD
On 2016/09/09 at 02:11:32, hinoka wrote:
> or just "shallow = " (not sure if assigning to a non-existant attr works)

done, and passed it through. assigning does work, but it was definitely ugly.

https://chromiumcodereview.appspot.com/2321203003/diff/20001/recipe_modules/b...
File recipe_modules/bot_update/resources/bot_update.py (right):

https://chromiumcodereview.appspot.com/2321203003/diff/20001/recipe_modules/b...
recipe_modules/bot_update/resources/bot_update.py:876:
parse.error('--revision_mapping_file is required')
On 2016/09/09 at 16:42:31, agable wrote:
> Can't you use required=True directly in argparse, rather than doing it out
here?

this is still using optparse which has a stupid opinion about required things
:(. 

Their argument:
Because its 'optparse', it's parsing 'options', and if an option is required,
then it's not an 'option', is it!? See how clever we are!

My argument:
Your library is useless because you don't understand how command lines work; I
will switch away from it at my earliest convenience. Good day.

[iannucci, 2016-09-09 22:30:04]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-09-09 22:30:05]

The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@chromium.org,
agable@chromium.org
Link to the patchset: https://codereview.chromium.org/2321203003/#ps40001
(title: "rebase, just in case")

[commit-bot: I haz the power, 2016-09-09 22:30:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 22:33:18]

Description was changed from

==========
A bunch more little cleanups in bot_update.

R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org,
martiniss@chromium.org
BUG=643885
==========

to

==========
A bunch more little cleanups in bot_update.

R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org,
martiniss@chromium.org
BUG=643885

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/d1d31d5d41b7d9...
==========

[commit-bot: I haz the power, 2016-09-09 22:33:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/d1d31d5d41b7d9...