Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2321173002: LogDog/Archivist: Conditionally render data. (Closed)

Created:
4 years, 3 months ago by dnj
Modified:
4 years, 3 months ago
Reviewers:
Ryan Tseng, iannucci, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog/Archivist: Conditionally render data. When archiving log stream data, LogDog's Archivist supports emitting a rendered data stream, which creates a flat file containing all of the log stream's data. This is useful for direct consumption, but not required. Because it doubles the amount of archival space required, it is gated on two conditions: - The project specifies that streams should always be rendered, or - The stream requests to be rendered to binary by providing an extension. Currently, these conditions are ignored, and the stream is always rendered. This patch makes the Archivist actually pay attention to this configuration and conditionally render the stream. BUG=chromium:643243 TEST=unittest Committed: https://github.com/luci/luci-go/commit/e1a482ae35e68cdbcb5385085e2d9a34219a50b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -26 lines) Patch
M logdog/server/archivist/archivist.go View 7 chunks +30 lines, -17 lines 0 comments Download
M logdog/server/archivist/archivist_test.go View 4 chunks +58 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dnj
PTAL
4 years, 3 months ago (2016-09-08 19:41:56 UTC) #2
Ryan Tseng
lgtm
4 years, 3 months ago (2016-09-08 19:54:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321173002/1
4 years, 3 months ago (2016-09-08 19:56:08 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 20:07:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/e1a482ae35e68cdbcb5385085e2d9a34219a50b8

Powered by Google App Engine
This is Rietveld 408576698