Allow MediaRouterDialogControllerImpl to re-set its reference to MRAction

Allow MediaRouterDialogControllerImpl to re-set its reference to MRAction

When a tab that a dialog controller is associated with gets moved to another
window, we need to allow the dialog controller to update its reference to the
toolbar action (associated with a window). This fixes the bug in which the
icon gets pressed in a wrong window.

The comment for SetMediaRouterAction() is also updated, as it is okay for the
action to be null, and we expect it to become null when it gets removed from
the toolbar.

BUG=644972
Committed: https://crrev.com/0a9c22d4d0a3c4335d69d00f28a8895d9583bab1
Cr-Commit-Position: refs/heads/master@{#417376}

[takumif, 2016-09-08 18:35:15]

Description was changed from

==========
Allow MediaRouterDialogControllerImpl to re-set its reference to MRAction

When a tab that a dialog controller is associated with gets moved to another
window, we need to allow the dialog controller to update its reference to the
toolbar action (associated with a window). This fixes the bug in which the
icon gets pressed in a wrong window.


BUG=644972
==========

to

==========
Allow MediaRouterDialogControllerImpl to re-set its reference to MRAction

When a tab that a dialog controller is associated with gets moved to another
window, we need to allow the dialog controller to update its reference to the
toolbar action (associated with a window). This fixes the bug in which the
icon gets pressed in a wrong window.

The comment for SetMediaRouterAction() is also updated, as it is okay for action
to be null.

BUG=644972
==========

[takumif, 2016-09-08 18:39:45]

Description was changed from

==========
Allow MediaRouterDialogControllerImpl to re-set its reference to MRAction

When a tab that a dialog controller is associated with gets moved to another
window, we need to allow the dialog controller to update its reference to the
toolbar action (associated with a window). This fixes the bug in which the
icon gets pressed in a wrong window.

The comment for SetMediaRouterAction() is also updated, as it is okay for action
to be null.

BUG=644972
==========

to

==========
Allow MediaRouterDialogControllerImpl to re-set its reference to MRAction

When a tab that a dialog controller is associated with gets moved to another
window, we need to allow the dialog controller to update its reference to the
toolbar action (associated with a window). This fixes the bug in which the
icon gets pressed in a wrong window.

The comment for SetMediaRouterAction() is also updated, as it is okay for the
action to be null, and we expect it to become null when it gets removed.

BUG=644972
==========

[takumif, 2016-09-08 18:40:35]

Description was changed from

==========
Allow MediaRouterDialogControllerImpl to re-set its reference to MRAction

When a tab that a dialog controller is associated with gets moved to another
window, we need to allow the dialog controller to update its reference to the
toolbar action (associated with a window). This fixes the bug in which the
icon gets pressed in a wrong window.

The comment for SetMediaRouterAction() is also updated, as it is okay for the
action to be null, and we expect it to become null when it gets removed.

BUG=644972
==========

to

==========
Allow MediaRouterDialogControllerImpl to re-set its reference to MRAction

When a tab that a dialog controller is associated with gets moved to another
window, we need to allow the dialog controller to update its reference to the
toolbar action (associated with a window). This fixes the bug in which the
icon gets pressed in a wrong window.

The comment for SetMediaRouterAction() is also updated, as it is okay for the
action to be null, and we expect it to become null when it gets removed from
the toolbar.

BUG=644972
==========

[takumif, 2016-09-08 18:46:01]

takumif@chromium.org changed reviewers:
+ imcheng@chromium.org

[takumif, 2016-09-08 18:46:01]

Please take a look, thank you!

[imcheng, 2016-09-08 19:00:24]

lgtm

[takumif, 2016-09-08 19:10:12]

The CQ bit was checked by takumif@chromium.org

[commit-bot: I haz the power, 2016-09-08 19:10:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 19:59:50]

Description was changed from

==========
Allow MediaRouterDialogControllerImpl to re-set its reference to MRAction

When a tab that a dialog controller is associated with gets moved to another
window, we need to allow the dialog controller to update its reference to the
toolbar action (associated with a window). This fixes the bug in which the
icon gets pressed in a wrong window.

The comment for SetMediaRouterAction() is also updated, as it is okay for the
action to be null, and we expect it to become null when it gets removed from
the toolbar.

BUG=644972
==========

to

==========
Allow MediaRouterDialogControllerImpl to re-set its reference to MRAction

When a tab that a dialog controller is associated with gets moved to another
window, we need to allow the dialog controller to update its reference to the
toolbar action (associated with a window). This fixes the bug in which the
icon gets pressed in a wrong window.

The comment for SetMediaRouterAction() is also updated, as it is okay for the
action to be null, and we expect it to become null when it gets removed from
the toolbar.

BUG=644972
==========

[commit-bot: I haz the power, 2016-09-08 19:59:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-08 20:01:40]

Description was changed from

==========
Allow MediaRouterDialogControllerImpl to re-set its reference to MRAction

When a tab that a dialog controller is associated with gets moved to another
window, we need to allow the dialog controller to update its reference to the
toolbar action (associated with a window). This fixes the bug in which the
icon gets pressed in a wrong window.

The comment for SetMediaRouterAction() is also updated, as it is okay for the
action to be null, and we expect it to become null when it gets removed from
the toolbar.

BUG=644972
==========

to

==========
Allow MediaRouterDialogControllerImpl to re-set its reference to MRAction

When a tab that a dialog controller is associated with gets moved to another
window, we need to allow the dialog controller to update its reference to the
toolbar action (associated with a window). This fixes the bug in which the
icon gets pressed in a wrong window.

The comment for SetMediaRouterAction() is also updated, as it is okay for the
action to be null, and we expect it to become null when it gets removed from
the toolbar.

BUG=644972

Committed: https://crrev.com/0a9c22d4d0a3c4335d69d00f28a8895d9583bab1
Cr-Commit-Position: refs/heads/master@{#417376}
==========

[commit-bot: I haz the power, 2016-09-08 20:01:41]

Patchset 1 (id:??) landed as
https://crrev.com/0a9c22d4d0a3c4335d69d00f28a8895d9583bab1
Cr-Commit-Position: refs/heads/master@{#417376}