Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2321113002: [turbofan] Introduces another DCHECK in the register allocator. (Closed)

Created:
4 years, 3 months ago by epertoso
Modified:
4 years, 3 months ago
Reviewers:
Mircea Trofin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduces another DCHECK in the register allocator. The previous DCHECK (removed in issue 2316033002) was checking that the new interval strictly overlapped with the first interval. BUG= Committed: https://crrev.com/f94f2ae20e01219004277ed5e082982fd2f48771 Cr-Commit-Position: refs/heads/master@{#39290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/compiler/register-allocator.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
epertoso
4 years, 3 months ago (2016-09-08 16:48:38 UTC) #3
Mircea Trofin
On 2016/09/08 16:48:38, epertoso wrote: lgtm
4 years, 3 months ago (2016-09-08 16:53:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321113002/1
4 years, 3 months ago (2016-09-08 17:17:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 17:18:37 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 17:19:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f94f2ae20e01219004277ed5e082982fd2f48771
Cr-Commit-Position: refs/heads/master@{#39290}

Powered by Google App Engine
This is Rietveld 408576698