Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5100)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2321083002: [NoStatePrefetch] Add performance histograms. (Closed)
Patch Set: Review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
index f2b9f3e31f54304ffe68b627f955d49f997f5bbd..6077b6a2abcbb8bbb72cb6d448b736bac50c8b94 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
@@ -4,10 +4,14 @@
#include "base/macros.h"
#include "base/test/histogram_tester.h"
+#include "base/time/time.h"
#include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
#include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h"
#include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h"
#include "chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h"
+#include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h"
+#include "chrome/browser/prerender/prerender_histograms.h"
+#include "chrome/browser/prerender/prerender_origin.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_navigator_params.h"
@@ -471,3 +475,39 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,
histogram_tester_.ExpectTotalCount(
internal::kHistogramParseStartToFirstMeaningfulPaint, 0);
}
+
+IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,
+ NoStatePrefetchObserverCacheable) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ ui_test_utils::NavigateToURL(browser(),
+ embedded_test_server()->GetURL("/title1.html"));
+ NavigateToUntrackedUrl();
+
+ histogram_tester_.ExpectTotalCount(
+ prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName(
+ prerender::ORIGIN_NONE, false, true, base::TimeDelta()),
+ 0);
+ histogram_tester_.ExpectTotalCount(
+ prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName(
+ prerender::ORIGIN_NONE, false, false, base::TimeDelta()),
+ 1);
+}
+
+IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,
+ NoStatePrefetchObserverNoStore) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ ui_test_utils::NavigateToURL(browser(),
+ embedded_test_server()->GetURL("/nostore.html"));
+ NavigateToUntrackedUrl();
+
+ histogram_tester_.ExpectTotalCount(
+ prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName(
+ prerender::ORIGIN_NONE, false, true, base::TimeDelta()),
+ 1);
+ histogram_tester_.ExpectTotalCount(
+ prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName(
+ prerender::ORIGIN_NONE, false, false, base::TimeDelta()),
+ 0);
+}

Powered by Google App Engine
This is Rietveld 408576698