Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h

Issue 2321083002: [NoStatePrefetch] Add performance histograms. (Closed)
Patch Set: rename url_ to start_url_ Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..3546fa4e43d2859d3dd7cb9983b972df94a55e4e
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h
@@ -0,0 +1,53 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_NO_STATE_PREFETCH_PAGE_LOAD_METRICS_OBSERVER_H_
+#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_NO_STATE_PREFETCH_PAGE_LOAD_METRICS_OBSERVER_H_
+
+#include "base/macros.h"
+#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
+#include "url/gurl.h"
+
+namespace content {
+class WebContents;
+}
+
+namespace page_load_metrics {
+class PageLoadTracker;
+}
+
+namespace prerender {
+class PrerenderManager;
+}
+
+// Observer recording metrics related to NoStatePrefetch.
+class NoStatePrefetchPageLoadMetricsObserver
+ : public page_load_metrics::PageLoadMetricsObserver {
+ public:
+ static void AddObserverIfNeeded(page_load_metrics::PageLoadTracker* tracker,
+ content::WebContents* web_contents);
+
+ explicit NoStatePrefetchPageLoadMetricsObserver(
+ prerender::PrerenderManager* manager);
+ ~NoStatePrefetchPageLoadMetricsObserver() override;
+
+ private:
+ // page_load_metrics::PageLoadMetricsObserver overrides:
+ void OnStart(content::NavigationHandle* navigation_handle,
+ const GURL& currently_committed_url,
+ bool started_in_foreground) override;
+ void OnCommit(content::NavigationHandle* navigation_handle) override;
+ void OnFirstContentfulPaint(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+
+ GURL start_url_; // URL of the page being loaded (before redirects).
+ bool is_no_store_; // True if the main resource has a "no-store" HTTP header.
+ bool navigation_committed_;
+ prerender::PrerenderManager* prerender_manager_;
mmenke 2016/09/15 17:20:44 const?
droger 2016/09/16 12:21:49 It cannot be const, since I call a non-const funct
mmenke 2016/09/16 16:53:48 I actually meant const after the asterisk (The add
droger 2016/09/19 09:55:23 Done.
+
+ DISALLOW_COPY_AND_ASSIGN(NoStatePrefetchPageLoadMetricsObserver);
+};
+
+#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_NO_STATE_PREFETCH_PAGE_LOAD_METRICS_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698