Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2321083002: [NoStatePrefetch] Add performance histograms. (Closed)
Patch Set: Added browser test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/test/histogram_tester.h" 6 #include "base/test/histogram_tester.h"
7 #include "base/time/time.h"
7 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h" 8 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
8 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h" 9 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"
9 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 10 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
10 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 11 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
12 #include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load _metrics_observer.h"
13 #include "chrome/browser/prerender/prerender_histograms.h"
14 #include "chrome/browser/prerender/prerender_origin.h"
11 #include "chrome/browser/ui/browser.h" 15 #include "chrome/browser/ui/browser.h"
12 #include "chrome/browser/ui/browser_navigator_params.h" 16 #include "chrome/browser/ui/browser_navigator_params.h"
13 #include "chrome/browser/ui/tabs/tab_strip_model.h" 17 #include "chrome/browser/ui/tabs/tab_strip_model.h"
14 #include "chrome/common/url_constants.h" 18 #include "chrome/common/url_constants.h"
15 #include "chrome/test/base/in_process_browser_test.h" 19 #include "chrome/test/base/in_process_browser_test.h"
16 #include "chrome/test/base/ui_test_utils.h" 20 #include "chrome/test/base/ui_test_utils.h"
17 #include "content/public/test/browser_test_utils.h" 21 #include "content/public/test/browser_test_utils.h"
18 #include "net/test/embedded_test_server/embedded_test_server.h" 22 #include "net/test/embedded_test_server/embedded_test_server.h"
19 23
20 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest { 24 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest {
(...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after
420 NavigateToUntrackedUrl(); 424 NavigateToUntrackedUrl();
421 425
422 histogram_tester_.ExpectUniqueSample( 426 histogram_tester_.ExpectUniqueSample(
423 internal::kHistogramFirstMeaningfulPaintStatus, 427 internal::kHistogramFirstMeaningfulPaintStatus,
424 internal::FIRST_MEANINGFUL_PAINT_DID_NOT_REACH_NETWORK_STABLE, 1); 428 internal::FIRST_MEANINGFUL_PAINT_DID_NOT_REACH_NETWORK_STABLE, 1);
425 histogram_tester_.ExpectTotalCount( 429 histogram_tester_.ExpectTotalCount(
426 internal::kHistogramFirstMeaningfulPaint, 0); 430 internal::kHistogramFirstMeaningfulPaint, 0);
427 histogram_tester_.ExpectTotalCount( 431 histogram_tester_.ExpectTotalCount(
428 internal::kHistogramParseStartToFirstMeaningfulPaint, 0); 432 internal::kHistogramParseStartToFirstMeaningfulPaint, 0);
429 } 433 }
434
435 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
Bryan McQuade 2016/09/19 16:35:02 i just landed a change that renamed these tests to
436 NoStatePrefetchObserverCacheable) {
437 ASSERT_TRUE(embedded_test_server()->Start());
438
439 ui_test_utils::NavigateToURL(browser(),
440 embedded_test_server()->GetURL("/title1.html"));
441 NavigateToUntrackedUrl();
442
443 histogram_tester_.ExpectTotalCount(
Bryan McQuade 2016/09/19 16:35:02 for completeness, can we also verify that the coun
444 prerender::PrerenderHistograms::GetFirstContentfulPaintHistogrameName(
445 prerender::ORIGIN_NONE, false, false, base::TimeDelta()),
446 1);
447 }
448
449 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
450 NoStatePrefetchObserverNoStore) {
451 ASSERT_TRUE(embedded_test_server()->Start());
452
453 ui_test_utils::NavigateToURL(browser(),
454 embedded_test_server()->GetURL("/nostore.html"));
455 NavigateToUntrackedUrl();
456
457 histogram_tester_.ExpectTotalCount(
Bryan McQuade 2016/09/19 16:35:02 likewise, let's verify that the non-no-store varia
458 prerender::PrerenderHistograms::GetFirstContentfulPaintHistogrameName(
459 prerender::ORIGIN_NONE, false, true, base::TimeDelta()),
460 1);
461 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698