Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2321073003: Disable flaky test testSetInitialScale (Closed)

Created:
4 years, 3 months ago by gogerald1
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky test testSetInitialScale BUG=644894 TBR=boliu@chromium.org Committed: https://crrev.com/f88ec63f0453d929edd2244f944357698eba6280 Cr-Commit-Position: refs/heads/master@{#417353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321073003/20001
4 years, 3 months ago (2016-09-08 18:51:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-08 18:55:50 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f88ec63f0453d929edd2244f944357698eba6280 Cr-Commit-Position: refs/heads/master@{#417353}
4 years, 3 months ago (2016-09-08 18:59:27 UTC) #15
boliu
you generally should add people you tbr to the reviewers list, so they get emailed, ...
4 years, 3 months ago (2016-09-08 19:54:43 UTC) #16
gogerald1
4 years, 3 months ago (2016-09-08 20:02:14 UTC) #17
Message was sent while issue was closed.
On 2016/09/08 19:54:43, boliu wrote:
> you generally should add people you tbr to the reviewers list, so they get
> emailed, even if you are not waiting for review

Ah, forgot it, sorry about that and thanks for reminding,

Powered by Google App Engine
This is Rietveld 408576698