Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2321063003: Ntp: add UMA for Learn More clicks. (Closed)

Created:
4 years, 3 months ago by Michael van Ouwerkerk
Modified:
4 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ntp: add UMA for Learn More clicks. BUG=641412 Committed: https://crrev.com/1a8e915dea8558bf33ca657332c02b8737ca30ab Cr-Commit-Position: refs/heads/master@{#417389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java View 2 chunks +6 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 3 months ago (2016-09-08 15:33:28 UTC) #4
Michael van Ouwerkerk
Ilya, could you take a look please as owner of histograms.xml?
4 years, 3 months ago (2016-09-08 15:35:18 UTC) #6
Michael van Ouwerkerk
s/isherman/asvitkine/ Alexei, could you take a look please as owner of histograms.xml?
4 years, 3 months ago (2016-09-08 15:36:16 UTC) #8
Bernhard Bauer
lgtm
4 years, 3 months ago (2016-09-08 16:01:46 UTC) #9
Alexei Svitkine (slow)
lgtm
4 years, 3 months ago (2016-09-08 16:57:24 UTC) #12
Ilya Sherman
histograms.xml lgtm
4 years, 3 months ago (2016-09-08 20:17:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321063003/1
4 years, 3 months ago (2016-09-08 20:34:28 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 20:39:49 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 20:42:59 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a8e915dea8558bf33ca657332c02b8737ca30ab
Cr-Commit-Position: refs/heads/master@{#417389}

Powered by Google App Engine
This is Rietveld 408576698