Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp

Issue 2321043002: Disable Math and Symbols segmentation, fix dotted circle sequence (Closed)
Patch Set: Fix comment wording Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp b/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp
index 99487cd94cb1b3da8657861e9b1b33559ec139f8..f0d00e8d8c79d07928517983ef609d00bf22fbae 100644
--- a/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp
+++ b/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp
@@ -96,7 +96,7 @@ TEST_F(SymbolsIteratorTest, LatinColorEmojiTextEmoji)
TEST_F(SymbolsIteratorTest, IgnoreVSInMath)
{
- CHECK_RUNS({ { "⊆⊇⊈\xEF\xB8\x8E⊙⊚⊚", FontFallbackPriority::Math } });
+ CHECK_RUNS({ { "⊆⊇⊈\xEF\xB8\x8E⊙⊚⊚", FontFallbackPriority::Text } });
}
TEST_F(SymbolsIteratorTest, IgnoreVS15InText)
@@ -129,6 +129,11 @@ TEST_F(SymbolsIteratorTest, SingleFlag)
CHECK_RUNS({ { "🇺", FontFallbackPriority::Text } });
}
+TEST_F(SymbolsIteratorTest, CombiningCircle)
+{
+ CHECK_RUNS({ { "◌́◌̀◌̈◌̂◌̄◌̊", FontFallbackPriority::Text } });
+}
+
// TODO: Perhaps check for invalid country indicator combinations?
TEST_F(SymbolsIteratorTest, FlagsVsNonFlags)
@@ -211,10 +216,7 @@ TEST_F(SymbolsIteratorTest, ExtraZWJPrefix)
TEST_F(SymbolsIteratorTest, Arrows)
{
- CHECK_RUNS({ { "x", FontFallbackPriority::Text },
- { "→←", FontFallbackPriority::Math },
- { "x", FontFallbackPriority::Text },
- { "←↑↓→", FontFallbackPriority::Math } });
+ CHECK_RUNS({ { "x→←x←↑↓→", FontFallbackPriority::Text } });
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698