Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2321043002: Disable Math and Symbols segmentation, fix dotted circle sequence (Closed)

Created:
4 years, 3 months ago by drott
Modified:
4 years, 3 months ago
Reviewers:
kojii, eae, behdad
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Math and Symbols segmentation, fix dotted circle sequence We currently do not use the Math and Symbols category for font selection, hence disabling it, since it was also breaking sequences of dotted circle plus combining marks which are frequently used to explain combining marks. BUG=641937 R=eae,kojii Committed: https://crrev.com/3ec36e0154e67ab8eda029ae5a234d581663e226 Cr-Commit-Position: refs/heads/master@{#417298}

Patch Set 1 #

Patch Set 2 : LayoutTest removed, coverage in unit test already #

Patch Set 3 : Fix comment wording #

Messages

Total messages: 19 (11 generated)
drott
LayoutTest removed, coverage in unit test already
4 years, 3 months ago (2016-09-08 13:06:21 UTC) #3
drott
Fix comment wording
4 years, 3 months ago (2016-09-08 13:09:32 UTC) #6
drott
4 years, 3 months ago (2016-09-08 13:13:11 UTC) #9
eae
LGTM
4 years, 3 months ago (2016-09-08 13:17:07 UTC) #10
behdad
lgtm
4 years, 3 months ago (2016-09-08 14:06:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321043002/40001
4 years, 3 months ago (2016-09-08 15:09:27 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-08 15:14:35 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 15:18:51 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3ec36e0154e67ab8eda029ae5a234d581663e226
Cr-Commit-Position: refs/heads/master@{#417298}

Powered by Google App Engine
This is Rietveld 408576698