Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 232103002: rebaseline_server: allow user to specify which builders to process (Closed)

Created:
6 years, 8 months ago by epoger
Modified:
6 years, 8 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: allow user to specify which builders to process BUG=skia:1543, skia:1915 NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=14131

Patch Set 1 : make SKIP_BUILDERS_PATTERN_LIST a property of BaseComparisons object #

Patch Set 2 : add match_builders_pattern_list, too #

Patch Set 3 : expose to command line #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -37 lines) Patch
M gm/rebaseline_server/compare_configs.py View 1 2 3 chunks +7 lines, -4 lines 2 comments Download
M gm/rebaseline_server/compare_rendered_pictures.py View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/rebaseline_server/compare_to_expectations.py View 1 2 5 chunks +8 lines, -9 lines 0 comments Download
M gm/rebaseline_server/results.py View 1 4 chunks +54 lines, -18 lines 0 comments Download
M gm/rebaseline_server/results_test.py View 1 1 chunk +23 lines, -0 lines 0 comments Download
M gm/rebaseline_server/server.py View 1 2 7 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Ready to review at patchset 3. https://codereview.chromium.org/232103002/diff/30001/gm/rebaseline_server/compare_configs.py File gm/rebaseline_server/compare_configs.py (right): https://codereview.chromium.org/232103002/diff/30001/gm/rebaseline_server/compare_configs.py#newcode1 gm/rebaseline_server/compare_configs.py:1: #!/usr/bin/python In some ...
6 years, 8 months ago (2014-04-10 03:49:29 UTC) #1
borenet
LGTM
6 years, 8 months ago (2014-04-10 13:23:21 UTC) #2
epoger
The CQ bit was checked by epoger@google.com
6 years, 8 months ago (2014-04-10 15:05:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/232103002/30001
6 years, 8 months ago (2014-04-10 15:05:11 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 15:05:38 UTC) #5
Message was sent while issue was closed.
Change committed as 14131

Powered by Google App Engine
This is Rietveld 408576698