blimp/client/core/contents/android/blimp_contents_observer_proxy.h - Issue 2320923002: Add a full Blimp integration test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/android/blimp_contents_observer_proxy.h

Issue 2320923002: Add a full Blimp integration test. (Closed)

Patch Set: Fixed this a bit more. Still some thread violations :(. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/contents/android/blimp_contents_observer_proxy.h

diff --git a/blimp/client/core/contents/android/blimp_contents_observer_proxy.h b/blimp/client/core/contents/android/blimp_contents_observer_proxy.h

index dec5df1e97e74b0a6d631b6b083f51697ee1559a..2af55e1cf7435ae1ffc8506058675268b98c6439 100644

--- a/blimp/client/core/contents/android/blimp_contents_observer_proxy.h

+++ b/blimp/client/core/contents/android/blimp_contents_observer_proxy.h

@@ -30,6 +30,7 @@ class BlimpContentsObserverProxy : public BlimpContentsObserver {

// BlimpContentsObserver implementation.

void OnNavigationStateChanged() override;

void OnLoadingStateChanged(bool loading) override;

+ void OnPageLoadingStateChanged(bool loading) override;

private:

base::android::ScopedJavaGlobalRef<jobject> java_obj_;