Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2740)

Unified Diff: blimp/client/core/blimp_client_context_impl.h

Issue 2320923002: Add a full Blimp integration test. (Closed)
Patch Set: Fix build break with chrome embedder Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/core/BUILD.gn ('k') | blimp/client/core/blimp_client_context_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/core/blimp_client_context_impl.h
diff --git a/blimp/client/core/blimp_client_context_impl.h b/blimp/client/core/blimp_client_context_impl.h
index 5df7ff90d45b988809019147063ecea99b42e488..2f8a270789bc225c8b97d4aab43b07120aec0585 100644
--- a/blimp/client/core/blimp_client_context_impl.h
+++ b/blimp/client/core/blimp_client_context_impl.h
@@ -59,6 +59,7 @@ class BlimpClientContextImpl
std::unique_ptr<BlimpContents> CreateBlimpContents(
gfx::NativeWindow window) override;
void Connect() override;
+ void ConnectWithAssignment(const Assignment& assignment) override;
// NetworkEventObserver implementation.
void OnConnected() override;
@@ -72,13 +73,14 @@ class BlimpClientContextImpl
IdentitySource* GetIdentitySource();
private:
- // Connect to assignment source with OAuth2 token to get an assignment.
- virtual void ConnectToAssignmentSource(const std::string& client_auth_token);
-
- // The AssignmentCallback for when an assignment is ready. This will trigger
- // a connection to the engine.
- virtual void ConnectWithAssignment(AssignmentRequestResult result,
- const Assignment& assignment);
+ // Called when an OAuth2 token is received. Will then ask the
+ // AssignmentSource for an Assignment with this token.
+ virtual void OnAuthTokenReceived(const std::string& client_auth_token);
+
+ // Called when the AssignmentSource is finished getting an Assignment. Will
+ // then call |ConnectWithAssignment| to initiate the actual connection.
+ virtual void OnAssignmentReceived(AssignmentRequestResult result,
+ const Assignment& assignment);
void RegisterFeatures();
void InitializeSettings();
« no previous file with comments | « blimp/client/core/BUILD.gn ('k') | blimp/client/core/blimp_client_context_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698