Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: blimp/client/public/blimp_client_context.h

Issue 2320923002: Add a full Blimp integration test. (Closed)
Patch Set: Fixed this a bit more. Still some thread violations :(. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_CLIENT_PUBLIC_BLIMP_CLIENT_CONTEXT_H_ 5 #ifndef BLIMP_CLIENT_PUBLIC_BLIMP_CLIENT_CONTEXT_H_
6 #define BLIMP_CLIENT_PUBLIC_BLIMP_CLIENT_CONTEXT_H_ 6 #define BLIMP_CLIENT_PUBLIC_BLIMP_CLIENT_CONTEXT_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 virtual void SetDelegate(BlimpClientContextDelegate* delegate) = 0; 57 virtual void SetDelegate(BlimpClientContextDelegate* delegate) = 0;
58 58
59 // Creates a new BlimpContents that will be shown in |window|. 59 // Creates a new BlimpContents that will be shown in |window|.
60 // TODO(mlliu): Currently we want to have a single BlimpContents. If there is 60 // TODO(mlliu): Currently we want to have a single BlimpContents. If there is
61 // an existing contents, return nullptr (http://crbug.com/642558). 61 // an existing contents, return nullptr (http://crbug.com/642558).
62 virtual std::unique_ptr<BlimpContents> CreateBlimpContents( 62 virtual std::unique_ptr<BlimpContents> CreateBlimpContents(
63 gfx::NativeWindow window) = 0; 63 gfx::NativeWindow window) = 0;
64 64
65 // Start authentication flow and connection to engine. 65 // Start authentication flow and connection to engine.
66 virtual void Connect() = 0; 66 virtual void Connect() = 0;
67 virtual void ConnectWithAssignment(const Assignment& assignment) = 0;
Khushal 2016/09/13 04:47:24 If its never meant to be used in production code,
David Trainor- moved to gerrit 2016/09/13 06:18:04 It's actually used by other methods internally whe
Khushal 2016/09/13 23:47:10 Its fine, doesn't look like something too bad to b
67 68
68 protected: 69 protected:
69 BlimpClientContext() = default; 70 BlimpClientContext() = default;
70 71
71 private: 72 private:
72 DISALLOW_COPY_AND_ASSIGN(BlimpClientContext); 73 DISALLOW_COPY_AND_ASSIGN(BlimpClientContext);
73 }; 74 };
74 75
75 } // namespace client 76 } // namespace client
76 } // namespace blimp 77 } // namespace blimp
77 78
78 #endif // BLIMP_CLIENT_PUBLIC_BLIMP_CLIENT_CONTEXT_H_ 79 #endif // BLIMP_CLIENT_PUBLIC_BLIMP_CLIENT_CONTEXT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698