Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2320903002:
Allow test_runner.py to run host perf tests without devices attached (Closed)
DescriptionAllow test_runner.py to run host perf tests without devices attached
BUG=644970
Committed: https://crrev.com/03345f562220323cf67948ec523eacaf6bb94e6f
Cr-Commit-Position: refs/heads/master@{#417295}
Patch Set 1 #
Total comments: 6
Patch Set 2 : address nits #
Messages
Total messages: 16 (7 generated)
Description was changed from ========== Allow test_runner.py to run host perf tests without devices attached BUG=644970 ========== to ========== Allow test_runner.py to run host perf tests without devices attached BUG=644970 ==========
agrieve@chromium.org changed reviewers: + jbudorick@chromium.org, rnephew@chromium.org
On 2016/09/08 02:30:44, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org, mailto:rnephew@chromium.org
https://codereview.chromium.org/2320903002/diff/1/build/android/pylib/local/d... File build/android/pylib/local/device/local_device_perf_test_run.py (right): https://codereview.chromium.org/2320903002/diff/1/build/android/pylib/local/d... build/android/pylib/local/device/local_device_perf_test_run.py:417: retries=0, timeout=self._timeout) nit: I'm fine with dropping retries, but I'd do it in a separate CL. https://codereview.chromium.org/2320903002/diff/1/build/android/pylib/local/d... build/android/pylib/local/device/local_device_perf_test_run.py:420: def shard_helper(shard_id): nit: maybe device_shard_helper https://codereview.chromium.org/2320903002/diff/1/build/android/pylib/local/d... build/android/pylib/local/device/local_device_perf_test_run.py:443: host_test_results, device_test_results = reraiser_thread.RunAsync( I'm wondering if there's a clean way to do shard creation separately by host/device, then run the shards all together w/ the parallelizer and something like def run_shard(shard): return s.RunTestsOnShard() shards = # logic to create host and device shards as necessary running_shards = parallelizer.Parallelizer(shards).pMap(run_shard) return [x for x in running_shards.pGet(self._timeout) if x is not None]
https://codereview.chromium.org/2320903002/diff/1/build/android/pylib/local/d... File build/android/pylib/local/device/local_device_perf_test_run.py (right): https://codereview.chromium.org/2320903002/diff/1/build/android/pylib/local/d... build/android/pylib/local/device/local_device_perf_test_run.py:417: retries=0, timeout=self._timeout) On 2016/09/08 02:45:59, jbudorick wrote: > nit: I'm fine with dropping retries, but I'd do it in a separate CL. Done. https://codereview.chromium.org/2320903002/diff/1/build/android/pylib/local/d... build/android/pylib/local/device/local_device_perf_test_run.py:443: host_test_results, device_test_results = reraiser_thread.RunAsync( On 2016/09/08 02:45:59, jbudorick wrote: > I'm wondering if there's a clean way to do shard creation separately by > host/device, then run the shards all together w/ the parallelizer and something > like > > def run_shard(shard): > return s.RunTestsOnShard() > > shards = # logic to create host and device shards as necessary > running_shards = parallelizer.Parallelizer(shards).pMap(run_shard) > return [x for x in running_shards.pGet(self._timeout) if x is not None] I think this could work so long as we still are careful to not query for devices when self._test_buckets == []. Okay to do it in a follow-up? I won't have time to figure that out tonight (I'm not sure I'm grokking the blacklisting part of this quite yet).
lgtm https://codereview.chromium.org/2320903002/diff/1/build/android/pylib/local/d... File build/android/pylib/local/device/local_device_perf_test_run.py (right): https://codereview.chromium.org/2320903002/diff/1/build/android/pylib/local/d... build/android/pylib/local/device/local_device_perf_test_run.py:443: host_test_results, device_test_results = reraiser_thread.RunAsync( On 2016/09/08 02:57:19, agrieve wrote: > On 2016/09/08 02:45:59, jbudorick wrote: > > I'm wondering if there's a clean way to do shard creation separately by > > host/device, then run the shards all together w/ the parallelizer and > something > > like > > > > def run_shard(shard): > > return s.RunTestsOnShard() > > > > shards = # logic to create host and device shards as necessary > > running_shards = parallelizer.Parallelizer(shards).pMap(run_shard) > > return [x for x in running_shards.pGet(self._timeout) if x is not None] > > I think this could work so long as we still are careful to not query for devices > when self._test_buckets == []. Okay to do it in a follow-up? I won't have time > to figure that out tonight (I'm not sure I'm grokking the blacklisting part of > this quite yet). Yeah, I'm fine with doing it in a follow-up. This version certainly has fewer moving parts than that one.
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Allow test_runner.py to run host perf tests without devices attached BUG=644970 ========== to ========== Allow test_runner.py to run host perf tests without devices attached BUG=644970 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Allow test_runner.py to run host perf tests without devices attached BUG=644970 ========== to ========== Allow test_runner.py to run host perf tests without devices attached BUG=644970 Committed: https://crrev.com/03345f562220323cf67948ec523eacaf6bb94e6f Cr-Commit-Position: refs/heads/master@{#417295} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/03345f562220323cf67948ec523eacaf6bb94e6f Cr-Commit-Position: refs/heads/master@{#417295} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
