Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: chrome/BUILD.gn

Issue 2320883006: 🍵 Refactor the various locale_paks() templates to be more shared (Closed)
Patch Set: sdefresne comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 1463 matching lines...) Expand 10 before | Expand all | Expand 10 after
1474 chrome_repack_locales("repack_locales_pack") { 1474 chrome_repack_locales("repack_locales_pack") {
1475 visibility = [ ":*" ] 1475 visibility = [ ":*" ]
1476 1476
1477 input_locales = locales 1477 input_locales = locales
1478 1478
1479 if (is_mac) { 1479 if (is_mac) {
1480 output_locales = locales_as_mac_outputs 1480 output_locales = locales_as_mac_outputs
1481 } else { 1481 } else {
1482 output_locales = locales 1482 output_locales = locales
1483 } 1483 }
1484
1485 if (enable_resource_whitelist_generation) {
1486 repack_whitelist = android_resource_whitelist
1487 deps += [ "//chrome:resource_whitelist" ]
1488 }
1484 } 1489 }
1485 1490
1486 chrome_repack_locales("repack_pseudo_locales_pack") { 1491 chrome_repack_locales("repack_pseudo_locales_pack") {
1487 visibility = [ ":*" ] 1492 visibility = [ ":*" ]
1488 1493
1489 input_locales = [ "fake-bidi" ] 1494 input_locales = [ "fake-bidi" ]
1490 1495
1491 if (is_mac) { 1496 if (is_mac) {
1492 output_locales = [ "fake_bidi" ] # Mac uses underscores. 1497 output_locales = [ "fake_bidi" ] # Mac uses underscores.
1493 } else { 1498 } else {
1494 output_locales = [ "fake-bidi" ] 1499 output_locales = [ "fake-bidi" ]
1495 } 1500 }
1501
1502 if (enable_resource_whitelist_generation) {
1503 repack_whitelist = android_resource_whitelist
1504 deps += [ "//chrome:resource_whitelist" ]
1505 }
1496 } 1506 }
1497 1507
1498 # Generates a rule to repack a set of resources, substituting a given string 1508 # Generates a rule to repack a set of resources, substituting a given string
1499 # in for the percentage (e.g. "100", "200"). It generates the repacked files in 1509 # in for the percentage (e.g. "100", "200"). It generates the repacked files in
1500 # the "gen" directory, and then introduces a copy rule to copy it to the root 1510 # the "gen" directory, and then introduces a copy rule to copy it to the root
1501 # build directory. 1511 # build directory.
1502 # 1512 #
1503 # It's not clear why this two-step dance is necessary as opposed to just 1513 # It's not clear why this two-step dance is necessary as opposed to just
1504 # generating the file in the destination. However, this is what the GYP build 1514 # generating the file in the destination. However, this is what the GYP build
1505 # does, and for maintenance purposes, this keeps the same files in the same 1515 # does, and for maintenance purposes, this keeps the same files in the same
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
1785 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1795 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1786 "//chrome/tools/build/linux/chrome-wrapper", 1796 "//chrome/tools/build/linux/chrome-wrapper",
1787 "//third_party/xdg-utils/scripts/xdg-mime", 1797 "//third_party/xdg-utils/scripts/xdg-mime",
1788 "//third_party/xdg-utils/scripts/xdg-settings", 1798 "//third_party/xdg-utils/scripts/xdg-settings",
1789 ] 1799 ]
1790 outputs = [ 1800 outputs = [
1791 "$root_out_dir/{{source_file_part}}", 1801 "$root_out_dir/{{source_file_part}}",
1792 ] 1802 ]
1793 } 1803 }
1794 } 1804 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698