Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2320873004:
Move device_management_backend.proto closer to the server version. (Closed)
|
Created:
4 years, 3 months ago by Thiemo Nagel Modified:
4 years, 2 months ago Reviewers:
bartfab (slow) CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove device_management_backend.proto closer to the server version.
No functional change, just updating comments and moving a block around.
BUG=645078
Committed: https://crrev.com/9b72e27717e3713ae3ca673f0afbfd99aa951c28
Cr-Commit-Position: refs/heads/master@{#421213}
Patch Set 1 #
Messages
Total messages: 21 (14 generated)
The CQ bit was checked by tnagel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was checked by tnagel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Move device_management_backend.proto closer to the server version. No functional change, just updating comments and moving blocks around. BUG=645078 ========== to ========== Move device_management_backend.proto closer to the server version. No functional change, just updating comments and moving a block around. BUG=645078 ==========
tnagel@chromium.org changed reviewers: + bartfab@chromium.org
Hi Bartosz, could you please take a look? Thank you! Thiemo
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Move device_management_backend.proto closer to the server version. No functional change, just updating comments and moving a block around. BUG=645078 ========== to ========== Move device_management_backend.proto closer to the server version. No functional change, just updating comments and moving a block around. BUG=645078 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Move device_management_backend.proto closer to the server version. No functional change, just updating comments and moving a block around. BUG=645078 ========== to ========== Move device_management_backend.proto closer to the server version. No functional change, just updating comments and moving a block around. BUG=645078 Committed: https://crrev.com/9b72e27717e3713ae3ca673f0afbfd99aa951c28 Cr-Commit-Position: refs/heads/master@{#421213} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9b72e27717e3713ae3ca673f0afbfd99aa951c28 Cr-Commit-Position: refs/heads/master@{#421213} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
