Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2320873002: Revert of Video capture Android: enable unittests for Camera2 API (Closed)

Created:
4 years, 3 months ago by aelias_OOO_until_Jul13
Modified:
4 years, 3 months ago
Reviewers:
emircan, jbudorick, mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Video capture Android: enable unittests for Camera2 API (patchset #5 id:220001 of https://codereview.chromium.org/2286303003/ ) Reason for revert: Caused WebViewLayoutTest#testMediaStreamApi and MediaAccessPermissionRequestTest#testGrantAccess to consistently fail. Confirmed locally by reverting patch, commenting out @DisableIf and running: ninja -C out/Release android_webview_test_apk android_webview_apk && out/Release/bin/run_android_webview_test_apk -f MediaAccessPermissionRequestTest.* BUG=644910 Original issue's description: > Video capture Android: enable unittests for Camera2 API > > This CL reenables a bunch of VideoCaptureDeviceTest > test cases for Android and for the "new" APIs > > For this: > - adds a |mTestMode| to VideoCapture.java, interface > of all camera java classes. VCCamera2.java tests this > flag and adds a capture thread if it's set. > - the C++ correspondent classes get a method to configure > the java side for testing, and a method to test if the > underlying platform is using the new or the old APIs. > > Also: > - Removes DeAllocateCameraWhileRunning because it was > equivalent to CaptureWithSize test case. > - Cleans up/refactors some parts of the unit tests, adds > a few more comments etc > > BUG=626857 > > Committed: https://crrev.com/7c32b70068c65b7bb372bb52a33d70b8e6653129 > Cr-Commit-Position: refs/heads/master@{#417015} TBR=jbudorick@chromium.org,emircan@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626857 Committed: https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc Cr-Commit-Position: refs/heads/master@{#417147}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
aelias_OOO_until_Jul13
Created Revert of Video capture Android: enable unittests for Camera2 API
4 years, 3 months ago (2016-09-08 01:27:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320873002/1
4 years, 3 months ago (2016-09-08 01:27:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 01:28:39 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 01:33:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc
Cr-Commit-Position: refs/heads/master@{#417147}

Powered by Google App Engine
This is Rietveld 408576698