Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Issue 2320853002: Optimize skia for performance, rather than size on all platforms. (Closed)

Created:
4 years, 3 months ago by erikchen
Modified:
4 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Optimize skia for performance, rather than size on all platforms. This change got lost in the GN migration. BUG=644927 Committed: https://crrev.com/be3d81886eb8db29ae0b204becaef10476b7faa5 Cr-Commit-Position: refs/heads/master@{#417682}

Patch Set 1 #

Patch Set 2 : CL for src perf tryjob to run thread_times.tough_scrolling_cases benchmark on all-mac platform(s) #

Patch Set 3 : CL for src perf tryjob to run smoothness.tough_path_rendering_cases benchmark on all-mac platform(s) #

Patch Set 4 : CL for src perf tryjob to run smoothness.top_25_smooth benchmark on all-mac platform(s) #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M skia/BUILD.gn View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 11 (3 generated)
erikchen
CL for src perf tryjob to run thread_times.tough_scrolling_cases benchmark on all-mac platform(s)
4 years, 3 months ago (2016-09-07 23:19:24 UTC) #1
erikchen
CL for src perf tryjob to run smoothness.tough_path_rendering_cases benchmark on all-mac platform(s)
4 years, 3 months ago (2016-09-07 23:19:49 UTC) #2
erikchen
CL for src perf tryjob to run smoothness.top_25_smooth benchmark on all-mac platform(s)
4 years, 3 months ago (2016-09-07 23:22:51 UTC) #3
erikchen
thakis: Please review.
4 years, 3 months ago (2016-09-09 18:47:24 UTC) #5
Nico
lgtm (https://bugs.chromium.org/p/chromium/issues/detail?id=641966#c10 -- but given that this was on on win and android but not ...
4 years, 3 months ago (2016-09-09 18:50:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320853002/60001
4 years, 3 months ago (2016-09-09 19:02:38 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-09 20:11:44 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 20:14:05 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/be3d81886eb8db29ae0b204becaef10476b7faa5
Cr-Commit-Position: refs/heads/master@{#417682}

Powered by Google App Engine
This is Rietveld 408576698