Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2320843004: Trivial TLS warning string change (Closed)

Created:
4 years, 3 months ago by felt
Modified:
4 years, 3 months ago
Reviewers:
lgarron
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trivial TLS warning string change The translate team pointed out that "this" doesn't bind to anything in this sentence. We really want to say "the certificate that Chrome received" but it would be unweildy, so just changing it to "its". Internal bug: b/31354544 R=lgarron@chromium.org Committed: https://crrev.com/faa6fd2599b6c5f010bda512d7a47469bb8a050f Cr-Commit-Position: refs/heads/master@{#417445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/security_interstitials_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
felt
lgarron, ptal
4 years, 3 months ago (2016-09-08 23:12:10 UTC) #1
lgarron
On 2016/09/08 at 23:12:10, felt wrote: > lgarron, ptal LGTM. I wish we had a ...
4 years, 3 months ago (2016-09-08 23:15:14 UTC) #2
felt
On 2016/09/08 23:15:14, lgarron wrote: > On 2016/09/08 at 23:12:10, felt wrote: > > lgarron, ...
4 years, 3 months ago (2016-09-08 23:17:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320843004/1
4 years, 3 months ago (2016-09-08 23:17:50 UTC) #5
lgarron
On 2016/09/08 at 23:17:50, commit-bot wrote: > CQ is trying da patch. Follow status at ...
4 years, 3 months ago (2016-09-08 23:21:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 23:58:50 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 00:01:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faa6fd2599b6c5f010bda512d7a47469bb8a050f
Cr-Commit-Position: refs/heads/master@{#417445}

Powered by Google App Engine
This is Rietveld 408576698