Add workaround for TextView.setCompoundDrawablesRelative() on JB MR1.

Add workaround for TextView.setCompoundDrawablesRelative() on JB MR1.

Due to a bug, TextView.setCompoundDrawablesRelative() is a no-op on JB
MR1 if the text view has ever been measured. This is fixed in JB MR2
onwards, but causes some ugly bugs in Chrome on JB MR1: e.g. the
favicons often don't appear on the bookmarks page.

BUG=361709
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263137

[newt (away), 2014-04-10 01:22:42]

PTAL

[Yaron, 2014-04-10 18:58:32]

lgtm for OWNERS but adding Ted in case he has other ideas. Given the linked bugs
I suppose it's reasonable but I don't know the ui code well enough

[newt (away), 2014-04-10 19:08:05]

On 2014/04/10 18:58:32, Yaron wrote:
> lgtm for OWNERS but adding Ted in case he has other ideas. Given the linked
bugs
> I suppose it's reasonable but I don't know the ui code well enough

Ted: if you compare TextView.setCompoundDrawablesRelativeWithIntrinsicBounds()
(which works correctly) to TextView.setCompoundDrawablesRelative() (which
doesn't work if the view has already been measured) in Android 4.2, you'll see
that the former method calls just calls the latter method after a) adjusting the
drawables' bounds, which is irrelevant here, and b) calling
resetResolvedDrawables().

http://androidxref.com/4.2.2_r1/xref/frameworks/base/core/java/android/widget...
http://androidxref.com/4.2.2_r1/xref/frameworks/base/core/java/android/widget...

I looked at other ways of indirectly triggering a call to
resetResolvedDrawables() (e.g. call
setCompoundDrawablesRelativeWithIntrinsicBounds(null, null, null, null), but
everything I came up with also then called resolveDrawables(), and hence didn't
work).

[Ted C, 2014-04-10 22:17:12]

On 2014/04/10 19:08:05, newt wrote:
> On 2014/04/10 18:58:32, Yaron wrote:
> > lgtm for OWNERS but adding Ted in case he has other ideas. Given the linked
> bugs
> > I suppose it's reasonable but I don't know the ui code well enough
> 
> Ted: if you compare TextView.setCompoundDrawablesRelativeWithIntrinsicBounds()
> (which works correctly) to TextView.setCompoundDrawablesRelative() (which
> doesn't work if the view has already been measured) in Android 4.2, you'll see
> that the former method calls just calls the latter method after a) adjusting
the
> drawables' bounds, which is irrelevant here, and b) calling
> resetResolvedDrawables().
> 
>
http://androidxref.com/4.2.2_r1/xref/frameworks/base/core/java/android/widget...
>
http://androidxref.com/4.2.2_r1/xref/frameworks/base/core/java/android/widget...
> 
> I looked at other ways of indirectly triggering a call to
> resetResolvedDrawables() (e.g. call
> setCompoundDrawablesRelativeWithIntrinsicBounds(null, null, null, null), but
> everything I came up with also then called resolveDrawables(), and hence
didn't
> work).

Yuck...but seems to be the best solution. lgtm

[newt (away), 2014-04-10 23:14:09]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2014-04-10 23:15:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/232083005/1

[commit-bot: I haz the power, 2014-04-11 00:00:30]

Change committed as 263137