Reland [Telemetry] Convert long running user stories to the System Health format.

Reland [Telemetry] Convert long running user stories to the System Health format.

Requires https://codereview.chromium.org/2228103002/

BUG=639315
Committed: https://crrev.com/8a487cef9afc07dc5d9ee7392b583f1da8be274a
Cr-Commit-Position: refs/heads/master@{#418256}

[rnephew (Reviews Here), 2016-09-07 18:35:48]

Description was changed from

==========
Reland [Telemetry] Convert long running user stories to the System Health
format.

BUG=639315
==========

to

==========
Reland [Telemetry] Convert long running user stories to the System Health
format.

Requires https://codereview.chromium.org/2228103002/

BUG=639315
==========

[rnephew (Reviews Here), 2016-09-07 18:36:21]

rnephew@chromium.org changed reviewers:
+ nednguyen@google.com, petrcermak@chromium.org

[rnephew (Reviews Here), 2016-09-09 18:24:57]

On 2016/09/07 18:36:22, rnephew (Reviews Here) wrote:

The other CL landed, PTAL.

[petrcermak, 2016-09-12 10:32:38]

LGTM.

Thanks,
Petr

[nednguyen, 2016-09-12 13:24:23]

https://codereview.chromium.org/2320783002/diff/1/tools/perf/benchmarks/syste...
File tools/perf/benchmarks/system_health_smoke_test.py (right):

https://codereview.chromium.org/2320783002/diff/1/tools/perf/benchmarks/syste...
tools/perf/benchmarks/system_health_smoke_test.py:53: # Permenently disabled
from smoke test for being long-running.
Let remove these, make a trybot run to see if there are any surprising failure,
then remove them & land the CL.

https://codereview.chromium.org/2320783002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/long_running_stories.py (right):

https://codereview.chromium.org/2320783002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/long_running_stories.py:25:
action_runner.tab.browser.tabs.New()
Good be nice if we also navigate to some other page here instead of just
about:blank.

[rnephew (Reviews Here), 2016-09-12 18:13:49]

The CQ bit was checked by rnephew@chromium.org to run a CQ dry run

[rnephew (Reviews Here), 2016-09-12 18:14:24]

https://codereview.chromium.org/2320783002/diff/1/tools/perf/benchmarks/syste...
File tools/perf/benchmarks/system_health_smoke_test.py (right):

https://codereview.chromium.org/2320783002/diff/1/tools/perf/benchmarks/syste...
tools/perf/benchmarks/system_health_smoke_test.py:53: # Permenently disabled
from smoke test for being long-running.
On 2016/09/12 13:24:23, nednguyen wrote:
> Let remove these, make a trybot run to see if there are any surprising
failure,
> then remove them & land the CL.

Running now.

https://codereview.chromium.org/2320783002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/long_running_stories.py (right):

https://codereview.chromium.org/2320783002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/long_running_stories.py:25:
action_runner.tab.browser.tabs.New()
On 2016/09/12 13:24:23, nednguyen wrote:
> Good be nice if we also navigate to some other page here instead of just
> about:blank. 

For now I would like to land it as-is since that is how the previous test
worked. I would like this CL to be a straight port of the old test and any
improvements/changes to be made in separate CL. I think we should have a
discussion with the memory-infra folks before making any change like this.

[commit-bot: I haz the power, 2016-09-12 18:14:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 19:28:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 19:28:26]

Dry run: This issue passed the CQ dry run.

[rnephew (Reviews Here), 2016-09-12 20:17:14]

On 2016/09/12 18:14:24, rnephew (Reviews Here) wrote:
>
https://codereview.chromium.org/2320783002/diff/1/tools/perf/benchmarks/syste...
> File tools/perf/benchmarks/system_health_smoke_test.py (right):
> 
>
https://codereview.chromium.org/2320783002/diff/1/tools/perf/benchmarks/syste...
> tools/perf/benchmarks/system_health_smoke_test.py:53: # Permenently disabled
> from smoke test for being long-running.
> On 2016/09/12 13:24:23, nednguyen wrote:
> > Let remove these, make a trybot run to see if there are any surprising
> failure,
> > then remove them & land the CL.
> 
> Running now.
> 
>
https://codereview.chromium.org/2320783002/diff/1/tools/perf/page_sets/system...
> File tools/perf/page_sets/system_health/long_running_stories.py (right):
> 
>
https://codereview.chromium.org/2320783002/diff/1/tools/perf/page_sets/system...
> tools/perf/page_sets/system_health/long_running_stories.py:25:
> action_runner.tab.browser.tabs.New()
> On 2016/09/12 13:24:23, nednguyen wrote:
> > Good be nice if we also navigate to some other page here instead of just
> > about:blank. 
> 
> For now I would like to land it as-is since that is how the previous test
> worked. I would like this CL to be a straight port of the old test and any
> improvements/changes to be made in separate CL. I think we should have a
> discussion with the memory-infra folks before making any change like this.

All try bots are green.

[nednguyen, 2016-09-12 20:29:52]

nednguyen@google.com changed reviewers:
+ perezju@chromium.org

[nednguyen, 2016-09-12 20:30:11]

On 2016/09/12 20:17:14, rnephew (Reviews Here) wrote:
> On 2016/09/12 18:14:24, rnephew (Reviews Here) wrote:
> >
>
https://codereview.chromium.org/2320783002/diff/1/tools/perf/benchmarks/syste...
> > File tools/perf/benchmarks/system_health_smoke_test.py (right):
> > 
> >
>
https://codereview.chromium.org/2320783002/diff/1/tools/perf/benchmarks/syste...
> > tools/perf/benchmarks/system_health_smoke_test.py:53: # Permenently disabled
> > from smoke test for being long-running.
> > On 2016/09/12 13:24:23, nednguyen wrote:
> > > Let remove these, make a trybot run to see if there are any surprising
> > failure,
> > > then remove them & land the CL.
> > 
> > Running now.
> > 
> >
>
https://codereview.chromium.org/2320783002/diff/1/tools/perf/page_sets/system...
> > File tools/perf/page_sets/system_health/long_running_stories.py (right):
> > 
> >
>
https://codereview.chromium.org/2320783002/diff/1/tools/perf/page_sets/system...
> > tools/perf/page_sets/system_health/long_running_stories.py:25:
> > action_runner.tab.browser.tabs.New()
> > On 2016/09/12 13:24:23, nednguyen wrote:
> > > Good be nice if we also navigate to some other page here instead of just
> > > about:blank. 
> > 
> > For now I would like to land it as-is since that is how the previous test
> > worked. I would like this CL to be a straight port of the old test and any
> > improvements/changes to be made in separate CL. I think we should have a
> > discussion with the memory-infra folks before making any change like this.
> 
> All try bots are green.

lgtm but let wait for Juan

[perezju, 2016-09-13 09:35:57]

lgtm

[rnephew (Reviews Here), 2016-09-13 14:33:17]

The CQ bit was checked by rnephew@chromium.org

[rnephew (Reviews Here), 2016-09-13 14:33:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
petrcermak@chromium.org, perezju@chromium.org, nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2320783002/#ps40001
(title: "disable smoke tests")

[commit-bot: I haz the power, 2016-09-13 14:33:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 15:35:49]

Description was changed from

==========
Reland [Telemetry] Convert long running user stories to the System Health
format.

Requires https://codereview.chromium.org/2228103002/

BUG=639315
==========

to

==========
Reland [Telemetry] Convert long running user stories to the System Health
format.

Requires https://codereview.chromium.org/2228103002/

BUG=639315
==========

[commit-bot: I haz the power, 2016-09-13 15:35:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-13 15:37:59]

Description was changed from

==========
Reland [Telemetry] Convert long running user stories to the System Health
format.

Requires https://codereview.chromium.org/2228103002/

BUG=639315
==========

to

==========
Reland [Telemetry] Convert long running user stories to the System Health
format.

Requires https://codereview.chromium.org/2228103002/

BUG=639315

Committed: https://crrev.com/8a487cef9afc07dc5d9ee7392b583f1da8be274a
Cr-Commit-Position: refs/heads/master@{#418256}
==========

[commit-bot: I haz the power, 2016-09-13 15:38:00]

Patchset 3 (id:??) landed as
https://crrev.com/8a487cef9afc07dc5d9ee7392b583f1da8be274a
Cr-Commit-Position: refs/heads/master@{#418256}