Support origin-based deletion for password store statistics

components/password_manager/core/browser/password_store.cc

Index: components/password_manager/core/browser/password_store.cc
diff --git a/components/password_manager/core/browser/password_store.cc b/components/password_manager/core/browser/password_store.cc
index c97af7539fff947fbff3a2c896e1becf28de3fae..ba2fc848bc046536f18a8249164298c5ab416c99 100644
--- a/components/password_manager/core/browser/password_store.cc
+++ b/components/password_manager/core/browser/password_store.cc
@@ -152,13 +152,15 @@ void PasswordStore::RemoveLoginsSyncedBetween(base::Time delete_begin,
                           this, delete_begin, delete_end));
 }
 
-void PasswordStore::RemoveStatisticsCreatedBetween(
+void PasswordStore::RemoveStatisticsByOriginAndTime(
+    const base::Callback<bool(const GURL&)>& origin_filter,
     base::Time delete_begin,
     base::Time delete_end,
     const base::Closure& completion) {
   ScheduleTask(
-      base::Bind(&PasswordStore::RemoveStatisticsCreatedBetweenInternal, this,
-                 delete_begin, delete_end, completion));
+      base::Bind(&PasswordStore::RemoveStatisticsByOriginAndTimeInternal, this,
+                 base::Callback<bool(const GURL&)>(origin_filter), delete_begin,

[vabr (Chromium), 2016/09/08 09:04:36]

Why do you need to create the temporary base::Callback<bool(const GURL&)>,
cannot you just pass the |origin_filter| reference directly to base::Bind (which
guarantees copying the callback, because you don't use ConstRef [1])?

[1]
https://cs.chromium.org/chromium/src/base/bind_helpers.h?q=bind+helpers+const...

[msramek, 2016/09/08 10:45:28]

Done. Yeah, I was a bit overzealous here.

+                 delete_end, completion));
 }
 
 void PasswordStore::DisableAutoSignInForOrigins(
@@ -424,11 +426,12 @@ void PasswordStore::RemoveLoginsSyncedBetweenInternal(base::Time delete_begin,
   NotifyLoginsChanged(changes);
 }
 
-void PasswordStore::RemoveStatisticsCreatedBetweenInternal(
+void PasswordStore::RemoveStatisticsByOriginAndTimeInternal(
+    const base::Callback<bool(const GURL&)>& origin_filter,
     base::Time delete_begin,
     base::Time delete_end,
     const base::Closure& completion) {
-  RemoveStatisticsCreatedBetweenImpl(delete_begin, delete_end);
+  RemoveStatisticsByOriginAndTimeImpl(origin_filter, delete_begin, delete_end);
   if (!completion.is_null())
     main_thread_runner_->PostTask(FROM_HERE, completion);
 }