Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Issue 2320753002: [turbofan] increased precision of range types for bitshifts (Closed)

Created:
4 years, 3 months ago by Tobias Tebbi
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] increased precision of range types for bitshifts BUG=v8:5296 Committed: https://crrev.com/744a6f7422de0995f7046d6fd4838494cdb20978 Cr-Commit-Position: refs/heads/master@{#41151}

Patch Set 1 #

Patch Set 2 : [turbofan] precise range analysis for bitshifts #

Total comments: 1

Patch Set 3 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -28 lines) Patch
M src/compiler/operation-typer.cc View 1 2 2 chunks +40 lines, -28 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Tobias Tebbi
4 years, 1 month ago (2016-11-21 09:56:22 UTC) #3
Jarin
LGTM (actually, looks awesome), modulo the nit. Thanks. https://codereview.chromium.org/2320753002/diff/20001/src/compiler/operation-typer.cc File src/compiler/operation-typer.cc (right): https://codereview.chromium.org/2320753002/diff/20001/src/compiler/operation-typer.cc#newcode801 src/compiler/operation-typer.cc:801: int32_t ...
4 years, 1 month ago (2016-11-21 10:34:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320753002/40001
4 years, 1 month ago (2016-11-21 16:21:22 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-21 16:46:03 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 16:46:32 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/744a6f7422de0995f7046d6fd4838494cdb20978
Cr-Commit-Position: refs/heads/master@{#41151}

Powered by Google App Engine
This is Rietveld 408576698