Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2320743002: Add ANGLE vulkan GN to gypi whitelist. (Closed)

Created:
4 years, 3 months ago by Jamie Madill
Modified:
4 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ANGLE vulkan GN to gypi whitelist. ANGLE still uses GYP for a standalone build. Until we switch to full GN (not currently being worked on) we need this script for all of our build files. BUG=605987 Committed: https://crrev.com/41d9f834db0041a7789eb79b63305982635c336a Cr-Commit-Position: refs/heads/master@{#417374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Jamie Madill
Brett PTAL, necessary for ANGLE/Vulkan.
4 years, 3 months ago (2016-09-07 16:46:03 UTC) #3
brettw
What is the timeline to get off of GYP?
4 years, 3 months ago (2016-09-07 18:23:12 UTC) #4
Jamie Madill
No timeline now, so this change is necessary. PTAL
4 years, 3 months ago (2016-09-07 18:28:08 UTC) #5
brettw
I don't think that we should generally be adding this kind of thing. I'd like ...
4 years, 3 months ago (2016-09-07 20:15:41 UTC) #6
brettw
lgtm
4 years, 3 months ago (2016-09-08 16:29:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320743002/1
4 years, 3 months ago (2016-09-08 18:32:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 19:57:36 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 19:59:09 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41d9f834db0041a7789eb79b63305982635c336a
Cr-Commit-Position: refs/heads/master@{#417374}

Powered by Google App Engine
This is Rietveld 408576698