Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2320733003: Remove final references to PackageUriResolver (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -31 lines) Patch
M pkg/analyzer/benchmark/errors_in_all_libraries.dart View 2 chunks +13 lines, -8 lines 0 comments Download
M pkg/analyzer/example/resolver_driver.dart View 2 chunks +5 lines, -3 lines 2 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 5 chunks +12 lines, -14 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/generate.dart View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
There is one remaining reference in cli, but I didn't want to postpone this CL ...
4 years, 3 months ago (2016-09-07 19:06:15 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2320733003/diff/1/pkg/analyzer/example/resolver_driver.dart File pkg/analyzer/example/resolver_driver.dart (right): https://codereview.chromium.org/2320733003/diff/1/pkg/analyzer/example/resolver_driver.dart#newcode47 pkg/analyzer/example/resolver_driver.dart:47: builder.convertPackagesToMap(builder.createPackageMap(packageRoot)))); We repeat this code in several clients. ...
4 years, 3 months ago (2016-09-07 19:11:39 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2320733003/diff/1/pkg/analyzer/example/resolver_driver.dart File pkg/analyzer/example/resolver_driver.dart (right): https://codereview.chromium.org/2320733003/diff/1/pkg/analyzer/example/resolver_driver.dart#newcode47 pkg/analyzer/example/resolver_driver.dart:47: builder.convertPackagesToMap(builder.createPackageMap(packageRoot)))); Eventually clients should be able to use an ...
4 years, 3 months ago (2016-09-07 20:03:03 UTC) #4
Brian Wilkerson
4 years, 3 months ago (2016-09-07 20:03:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
771d296a6c920e5d83c5dd957a45021bfe2adcc6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698