[wasm] Compilation/Instantiation pipeline works off module object

test/cctest/wasm/wasm-module-runner.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "test/cctest/wasm/wasm-module-runner.h"
 
 #include "src/handles.h"
 #include "src/isolate.h"
 #include "src/objects.h"
 #include "src/property-descriptor.h"
@@ skipping 41 matching lines @@
 
   if (module->import_table.size() > 0) {
     thrower.Error("Not supported: module has imports.");
   }
   if (module->export_table.size() == 0) {
     thrower.Error("Not supported: module has no exports.");
   }
 
   if (thrower.error()) return Handle<JSObject>::null();
 
-  MaybeHandle<FixedArray> compiled_module =
-      module->CompileFunctions(isolate, &thrower);
-
-  if (compiled_module.is_null()) return Handle<JSObject>::null();
-  return WasmModule::Instantiate(isolate, compiled_module.ToHandleChecked(),
+  // Although we decoded the module for some pre-validation, run the bytes
+  // again through the normal pipeline.
+  MaybeHandle<JSObject> module_object = CreateModuleObjectFromBytes(
+      isolate, module->module_start, module->module_end, &thrower,
+      ModuleOrigin::kWasmOrigin);
+  if (module_object.is_null()) return Handle<JSObject>::null();
+  return WasmModule::Instantiate(isolate, module_object.ToHandleChecked(),
                                  Handle<JSReceiver>::null(),
                                  Handle<JSArrayBuffer>::null())
       .ToHandleChecked();
 }
 
 int32_t CompileAndRunWasmModule(Isolate* isolate, const byte* module_start,
-                                const byte* module_end, bool asm_js) {
+                                const byte* module_end, ModuleOrigin origin) {
   HandleScope scope(isolate);
   Zone zone(isolate->allocator());
 
   ErrorThrower thrower(isolate, "CompileAndRunWasmModule");
   std::unique_ptr<const WasmModule> module(DecodeWasmModuleForTesting(
-      isolate, &zone, thrower, module_start, module_end,
-      asm_js ? kAsmJsOrigin : kWasmOrigin));
+      isolate, &zone, thrower, module_start, module_end, origin));
 
   if (module == nullptr) {
     return -1;
   }
   Handle<JSObject> instance =
       InstantiateModuleForTesting(isolate, thrower, module.get());
   if (instance.is_null()) {
     return -1;
   }
-  return CallWasmFunctionForTesting(isolate, instance, thrower,
-                                    asm_js ? "caller" : "main", 0, nullptr,
-                                    asm_js);
+  const char* f_name = origin == ModuleOrigin::kAsmJsOrigin ? "caller" : "main";
+  return CallWasmFunctionForTesting(isolate, instance, thrower, f_name, 0,
+                                    nullptr, origin);
 }
 
 int32_t InterpretWasmModule(Isolate* isolate, ErrorThrower& thrower,
                             const WasmModule* module, int function_index,
                             WasmVal* args) {
   CHECK(module != nullptr);
 
   Zone zone(isolate->allocator());
   v8::internal::HandleScope scope(isolate);
 
@@ skipping 40 matching lines @@
     return 0xdeadbeef;
   } else {
     thrower.Error("Interpreter did not finish execution within its step bound");
     return -1;
   }
 }
 
 int32_t CallWasmFunctionForTesting(Isolate* isolate, Handle<JSObject> instance,
                                    ErrorThrower& thrower, const char* name,
                                    int argc, Handle<Object> argv[],
-                                   bool asm_js) {
+                                   ModuleOrigin origin) {
   Handle<JSObject> exports_object;
-  if (asm_js) {
+  if (origin == ModuleOrigin::kAsmJsOrigin) {
     exports_object = instance;
   } else {
     Handle<Name> exports = isolate->factory()->InternalizeUtf8String("exports");
     exports_object = Handle<JSObject>::cast(
         JSObject::GetProperty(instance, exports).ToHandleChecked());
   }
   Handle<Name> main_name = isolate->factory()->NewStringFromAsciiChecked(name);
   PropertyDescriptor desc;
   Maybe<bool> property_found = JSReceiver::GetOwnPropertyDescriptor(
       isolate, exports_object, main_name, &desc);
@@ skipping 19 matching lines @@
     return static_cast<int32_t>(HeapNumber::cast(*result)->value());
   }
   thrower.Error("WASM.compileRun() failed: Return value should be number");
   return -1;
 }
 
 }  // namespace testing
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8