Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: components/content_settings/core/browser/content_settings_pref_provider.cc

Issue 2320723002: Remove some obsolete prefs. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/content_settings/core/browser/content_settings_pref_provider.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/content_settings/core/browser/content_settings_pref_provider.cc
diff --git a/components/content_settings/core/browser/content_settings_pref_provider.cc b/components/content_settings/core/browser/content_settings_pref_provider.cc
index caa4c7b77c54d448736ebd39fb489331bc0c5440..8d451633e2c74e43f097bb7f6c52349dfea9e8e3 100644
--- a/components/content_settings/core/browser/content_settings_pref_provider.cc
+++ b/components/content_settings/core/browser/content_settings_pref_provider.cc
@@ -15,7 +15,6 @@
#include "base/bind.h"
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
-#include "base/strings/string_split.h"
#include "base/time/clock.h"
#include "base/time/default_clock.h"
#include "components/content_settings/core/browser/content_settings_pref.h"
@@ -32,18 +31,6 @@
#include "components/prefs/pref_service.h"
#include "components/prefs/scoped_user_pref_update.h"
-namespace {
-
-// Obsolete prefs.
-// TODO(msramek): Remove the cleanup code after two releases (i.e. in M50).
-const char kObsoleteMetroSwitchToDesktopExceptions[] =
- "profile.content_settings.exceptions.metro_switch_to_desktop";
-
-const char kObsoleteMediaStreamExceptions[] =
- "profile.content_settings.exceptions.media_stream";
-
-} // namespace
-
namespace content_settings {
// ////////////////////////////////////////////////////////////////////////////
@@ -63,14 +50,6 @@ void PrefProvider::RegisterProfilePrefs(
registry->RegisterDictionaryPref(info->pref_name(),
info->GetPrefRegistrationFlags());
}
-
- // Obsolete prefs ----------------------------------------------------------
-
- registry->RegisterDictionaryPref(
- kObsoleteMetroSwitchToDesktopExceptions,
- user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
-
- registry->RegisterDictionaryPref(kObsoleteMediaStreamExceptions);
}
PrefProvider::PrefProvider(PrefService* prefs, bool incognito)
@@ -109,8 +88,6 @@ PrefProvider::PrefProvider(PrefService* prefs, bool incognito)
UMA_HISTOGRAM_COUNTS("ContentSettings.NumberOfExceptions",
num_exceptions);
}
-
- DiscardObsoletePreferences();
}
PrefProvider::~PrefProvider() {
@@ -210,9 +187,4 @@ void PrefProvider::Notify(
resource_identifier);
}
-void PrefProvider::DiscardObsoletePreferences() {
- prefs_->ClearPref(kObsoleteMetroSwitchToDesktopExceptions);
- prefs_->ClearPref(kObsoleteMediaStreamExceptions);
-}
-
} // namespace content_settings
« no previous file with comments | « components/content_settings/core/browser/content_settings_pref_provider.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698