Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: components/content_settings/core/browser/content_settings_default_provider.cc

Issue 2320723002: Remove some obsolete prefs. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/content_settings_default_provider.cc
diff --git a/components/content_settings/core/browser/content_settings_default_provider.cc b/components/content_settings/core/browser/content_settings_default_provider.cc
index 126bc41de71186de4931f6bb822ad2b3556b619f..f63ab69ca365f684665bfa9f64a700f05ccb73b9 100644
--- a/components/content_settings/core/browser/content_settings_default_provider.cc
+++ b/components/content_settings/core/browser/content_settings_default_provider.cc
@@ -9,7 +9,6 @@
#include "base/auto_reset.h"
#include "base/bind.h"
-#include "base/command_line.h"
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
#include "components/content_settings/core/browser/content_settings_rule.h"
@@ -29,15 +28,6 @@ namespace content_settings {
namespace {
-// Obsolete prefs to be removed from the pref file.
-// TODO(msramek): Remove this cleanup code after two releases (i.e. in M50).
-const char kObsoleteMetroSwitchToDesktopSetting[] =
- "profile.default_content_setting_values.metro_switch_to_desktop";
-
-// TODO(msramek): Remove this cleanup code after two releases (i.e. in M51).
-const char kObsoleteMediaStreamSetting[] =
- "profile.default_content_setting_values.media_stream";
-
ContentSetting GetDefaultValue(const WebsiteSettingsInfo* info) {
const base::Value* initial_default = info->initial_default_value();
if (!initial_default)
@@ -91,17 +81,6 @@ void DefaultProvider::RegisterProfilePrefs(
GetDefaultValue(info),
info->GetPrefRegistrationFlags());
}
-
- // Obsolete prefs -------------------------------------------------------
-
- // The removed content settings type METRO_SWITCH_TO_DESKTOP.
- registry->RegisterIntegerPref(
- kObsoleteMetroSwitchToDesktopSetting,
- 0,
- user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
-
- // The removed content settings type MEDIASTREAM.
- registry->RegisterIntegerPref(kObsoleteMediaStreamSetting, 0);
}
DefaultProvider::DefaultProvider(PrefService* prefs, bool incognito)
@@ -110,9 +89,6 @@ DefaultProvider::DefaultProvider(PrefService* prefs, bool incognito)
updating_preferences_(false) {
DCHECK(prefs_);
- // Remove the obsolete preferences from the pref file.
- DiscardObsoletePreferences();
-
// Read global defaults.
ReadDefaultSettings();
@@ -367,9 +343,4 @@ std::unique_ptr<base::Value> DefaultProvider::ReadFromPref(
return ContentSettingToValue(IntToContentSetting(int_value));
}
-void DefaultProvider::DiscardObsoletePreferences() {
- prefs_->ClearPref(kObsoleteMetroSwitchToDesktopSetting);
- prefs_->ClearPref(kObsoleteMediaStreamSetting);
-}
-
} // namespace content_settings

Powered by Google App Engine
This is Rietveld 408576698