Remove calls to IsRunningSequenceOnCurrentThread() from log_private_api_chromeos.cc

Remove calls to IsRunningSequenceOnCurrentThread() from log_private_api_chromeos.cc

SequencedWorkerPool is being migrated to base/task_scheduler and there
is no equivalent to IsRunningSequenceOnCurrentThread() in
base/task_scheduler.

Developers should use SequenceChecker to verify that tasks run
sequentially. Unlike
SequencedWorkerPool::IsRunningSequenceOnCurrentThread(),
SequenceChecker works everywhere in Chrome (MessageLoop,
SequencedWorkerPool, base/task_scheduler...).

Also, we believe that always doing work asynchronously is cleaner
than doing it synchronously part of the time.

BUG=622400
Committed: https://crrev.com/fbfbd92b1292d38c0ef2b3fa7e8ac7b4667ed0dc
Cr-Commit-Position: refs/heads/master@{#417087}

[fdoray, 2016-09-07 15:19:11]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 15:19:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 16:03:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 16:03:15]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-09-07 16:07:23]

fdoray@chromium.org changed reviewers:
+ reillyg@chromium.org

[fdoray, 2016-09-07 16:07:24]

PTAL

[Reilly Grant (use Gerrit), 2016-09-07 18:00:05]

https://codereview.chromium.org/2320703002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
(right):

https://codereview.chromium.org/2320703002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc:285:
RegisterTempFile(owner_extension_id, file_path);
I believe this change is going to change the semantics of this line because the
new temp file will not be registered synchronously.

[fdoray, 2016-09-07 19:33:41]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 19:34:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-09-07 19:43:11]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 19:43:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-09-07 20:17:42]

PTAnL

https://codereview.chromium.org/2320703002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
(right):

https://codereview.chromium.org/2320703002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc:285:
RegisterTempFile(owner_extension_id, file_path);
On 2016/09/07 18:00:05, Reilly Grant wrote:
> I believe this change is going to change the semantics of this line because
the
> new temp file will not be registered synchronously.

Right. Fixed in latest patch set.

[commit-bot: I haz the power, 2016-09-07 20:33:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 20:33:01]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2016-09-07 21:36:37]

lgtm

[fdoray, 2016-09-07 22:08:39]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-09-07 22:09:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 22:17:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-07 22:19:25]

Description was changed from

==========
Remove calls to IsRunningSequenceOnCurrentThread() from
log_private_api_chromeos.cc

SequencedWorkerPool is being migrated to base/task_scheduler and there
is no equivalent to IsRunningSequenceOnCurrentThread() in
base/task_scheduler.

Developers should use SequenceChecker to verify that tasks run
sequentially. Unlike
SequencedWorkerPool::IsRunningSequenceOnCurrentThread(),
SequenceChecker works everywhere in Chrome (MessageLoop,
SequencedWorkerPool, base/task_scheduler...).

Also, we believe that always doing work asynchronously is cleaner
than doing it synchronously part of the time.

BUG=622400
==========

to

==========
Remove calls to IsRunningSequenceOnCurrentThread() from
log_private_api_chromeos.cc

SequencedWorkerPool is being migrated to base/task_scheduler and there
is no equivalent to IsRunningSequenceOnCurrentThread() in
base/task_scheduler.

Developers should use SequenceChecker to verify that tasks run
sequentially. Unlike
SequencedWorkerPool::IsRunningSequenceOnCurrentThread(),
SequenceChecker works everywhere in Chrome (MessageLoop,
SequencedWorkerPool, base/task_scheduler...).

Also, we believe that always doing work asynchronously is cleaner
than doing it synchronously part of the time.

BUG=622400

Committed: https://crrev.com/fbfbd92b1292d38c0ef2b3fa7e8ac7b4667ed0dc
Cr-Commit-Position: refs/heads/master@{#417087}
==========

[commit-bot: I haz the power, 2016-09-07 22:19:26]

Patchset 3 (id:??) landed as
https://crrev.com/fbfbd92b1292d38c0ef2b3fa7e8ac7b4667ed0dc
Cr-Commit-Position: refs/heads/master@{#417087}