Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2320693003: [Download Home] Expose Java side to DownloadItem states (Closed)

Created:
4 years, 3 months ago by gone
Modified:
4 years, 3 months ago
Reviewers:
asanka, qinmin, jam
CC:
asanka, chromium-reviews, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Download Home] Expose Java side to DownloadItem states * Expose DownloadItem::DownloadState to Java as an enum. * Pass all DownloadItem updates to Java so that the DownloadHistoryAdapter can process them. We're still ignoring everything but the COMPLETE state. BUG=616324 Committed: https://crrev.com/145c6422c5188bad9e5cc28a9acbf72c407b4045 Cr-Commit-Position: refs/heads/master@{#417439}

Patch Set 1 #

Patch Set 2 : Rebased #

Messages

Total messages: 17 (9 generated)
gone
Not much going on in this CL, but it touches a few directories. Asanka for ...
4 years, 3 months ago (2016-09-07 20:05:39 UTC) #2
gone
-sievers because he's OOO. +jam for changes to content/
4 years, 3 months ago (2016-09-07 21:26:31 UTC) #8
qinmin
lgtm
4 years, 3 months ago (2016-09-07 21:52:11 UTC) #9
jam
lgtm
4 years, 3 months ago (2016-09-08 18:08:27 UTC) #10
asanka
lgtm
4 years, 3 months ago (2016-09-08 21:23:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320693003/20001
4 years, 3 months ago (2016-09-08 22:20:40 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 23:45:48 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 23:50:07 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/145c6422c5188bad9e5cc28a9acbf72c407b4045
Cr-Commit-Position: refs/heads/master@{#417439}

Powered by Google App Engine
This is Rietveld 408576698