Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2320643002: Remove calls to IsRunningSequenceOnCurrentThread() from memory_dump_manager_unittest.cc (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to IsRunningSequenceOnCurrentThread() from memory_dump_manager_unittest.cc SequencedWorkerPool is being migrated to base/task_scheduler and there is no equivalent to IsRunningSequenceOnCurrentThread() in base/task_scheduler. BUG=622400 Committed: https://crrev.com/ee7a59389604bc254617c71ef53aaf0eaf9c7237 Cr-Commit-Position: refs/heads/master@{#416994}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/trace_event/memory_dump_manager_unittest.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 14 (9 generated)
fdoray
PTAL https://codereview.chromium.org/2320643002/diff/1/base/trace_event/memory_dump_manager_unittest.cc File base/trace_event/memory_dump_manager_unittest.cc (right): https://codereview.chromium.org/2320643002/diff/1/base/trace_event/memory_dump_manager_unittest.cc#newcode190 base/trace_event/memory_dump_manager_unittest.cc:190: bool RunsTasksOnCurrentThread() const override { RunsTasksOnCurrentThread() is supposed ...
4 years, 3 months ago (2016-09-07 14:36:15 UTC) #7
Primiano Tucci (use gerrit)
lgtm
4 years, 3 months ago (2016-09-07 17:43:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320643002/1
4 years, 3 months ago (2016-09-07 17:58:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 18:03:28 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 18:04:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee7a59389604bc254617c71ef53aaf0eaf9c7237
Cr-Commit-Position: refs/heads/master@{#416994}

Powered by Google App Engine
This is Rietveld 408576698