GN: Don't write duplicate phony rules.

GN: Don't write duplicate phony rules.

In GN it's possible to have targets with the same short name as long as the files in the root dir don't collide. This is easiest to get with source_sets, where there is no output file and you don't have to worry about naming at all.

But currently Ninja will complain about duplicate rules since we write "short" phony rules for each target. This patch skips the phony rule shortcuts for targets with duplicate names. The places where I was seeing the collision problems was in the "test_support" type target where there is little reason to use the short name anyway.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262874

[scottmg, 2014-04-09 21:52:46]

lgtm

[brettw, 2014-04-09 21:55:42]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-04-09 21:56:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/brettw@chromium.org/232063002/1

[brettw, 2014-04-09 22:11:37]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2014-04-09 22:12:16]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-04-09 22:12:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/brettw@chromium.org/232063002/20001

[commit-bot: I haz the power, 2014-04-10 00:25:26]

Change committed as 262874