| 
    
      
  | 
  
 Chromium Code Reviews| 
         Created: 
          4 years, 3 months ago by bpastene Modified: 
          
          
          4 years, 3 months ago CC: 
          
          
          
          chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Target Ref: 
          
          
          refs/heads/master Project: 
          
          depot_tools Visibility: 
          
          
          
        Public.  | 
      
        
  Descriptiongclient: Prune dangling remote tracking refs when fetching with --force
BUG=644722
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/2a3e9913bec46ddaf1c82f3328202f7a6092df2f
   
  Patch Set 1 #Patch Set 2 : only on --force #
      Total comments: 2
      
     
  
  Patch Set 3 : inline #Messages
    Total messages: 25 (12 generated)
     
  
  
 The CQ bit was checked by bpastene@chromium.org to run a CQ dry run 
 Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... 
 bpastene@chromium.org changed reviewers: + iannucci@chromium.org 
 talp! 
 lgtm https://chromiumcodereview.appspot.com/2320573005/diff/20001/gclient_scm.py File gclient_scm.py (right): https://chromiumcodereview.appspot.com/2320573005/diff/20001/gclient_scm.py#n... gclient_scm.py:1239: self._Fetch(options, prune=True) self._Fetch(options, prune=options.force) 
 https://codereview.chromium.org/2320573005/diff/20001/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/2320573005/diff/20001/gclient_scm.py#newcode1239 gclient_scm.py:1239: self._Fetch(options, prune=True) On 2016/09/07 21:46:13, iannucci wrote: > self._Fetch(options, prune=options.force) Done. 
 The CQ bit was checked by bpastene@chromium.org 
 The patchset sent to the CQ was uploaded after l-g-t-m from iannucci@chromium.org Link to the patchset: https://codereview.chromium.org/2320573005/#ps40001 (title: "inline") 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Try jobs failed on following builders: Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/311f74533abc6b10) 
 The CQ bit was checked by jbudorick@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... 
 On 2016/09/07 22:09:58, jbudorick wrote: > The CQ bit was checked by mailto:jbudorick@chromium.org I think this should work now that https://codereview.chromium.org/2322663002/ rolled into chromium, but this would appear to be a structural flaw: nothing can land here between a build/ side recipe change that causes a nontrivial expectations change in chromium and the resulting recipe roll in chromium. 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Try jobs failed on following builders: Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/311f852406ce4410) 
 On 2016/09/07 22:23:23, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED, > https://luci-milo.appspot.com/swarming/task/311f852406ce4410) Now borked on https://codereview.chromium.org/2318413002 rolling into chromium. 
 The CQ bit was checked by bpastene@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Try jobs failed on following builders: Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/311faa0b84ffd110) 
 The CQ bit was checked by bpastene@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Description was changed from ========== gclient: Prune dangling remote tracking refs when fetching with --force BUG=644722 ========== to ========== gclient: Prune dangling remote tracking refs when fetching with --force BUG=644722 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/2a3e9913bec46d... ========== 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/2a3e9913bec46d...  | 
    
