Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 2320573005: gclient: Prune dangling remote tracking refs when fetching with --force (Closed)

Created:
4 years, 3 months ago by bpastene
Modified:
4 years, 3 months ago
Reviewers:
iannucci, jbudorick
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

gclient: Prune dangling remote tracking refs when fetching with --force BUG=644722 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/2a3e9913bec46ddaf1c82f3328202f7a6092df2f

Patch Set 1 #

Patch Set 2 : only on --force #

Total comments: 2

Patch Set 3 : inline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gclient_scm.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (12 generated)
bpastene
talp!
4 years, 3 months ago (2016-09-07 21:40:05 UTC) #4
iannucci
lgtm https://chromiumcodereview.appspot.com/2320573005/diff/20001/gclient_scm.py File gclient_scm.py (right): https://chromiumcodereview.appspot.com/2320573005/diff/20001/gclient_scm.py#newcode1239 gclient_scm.py:1239: self._Fetch(options, prune=True) self._Fetch(options, prune=options.force)
4 years, 3 months ago (2016-09-07 21:46:13 UTC) #5
bpastene
https://codereview.chromium.org/2320573005/diff/20001/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/2320573005/diff/20001/gclient_scm.py#newcode1239 gclient_scm.py:1239: self._Fetch(options, prune=True) On 2016/09/07 21:46:13, iannucci wrote: > self._Fetch(options, ...
4 years, 3 months ago (2016-09-07 21:51:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320573005/40001
4 years, 3 months ago (2016-09-07 21:51:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/311f74533abc6b10)
4 years, 3 months ago (2016-09-07 22:05:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320573005/40001
4 years, 3 months ago (2016-09-07 22:10:07 UTC) #13
jbudorick
On 2016/09/07 22:09:58, jbudorick wrote: > The CQ bit was checked by mailto:jbudorick@chromium.org I think ...
4 years, 3 months ago (2016-09-07 22:12:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/311f852406ce4410)
4 years, 3 months ago (2016-09-07 22:23:23 UTC) #16
jbudorick
On 2016/09/07 22:23:23, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-07 22:27:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320573005/40001
4 years, 3 months ago (2016-09-07 22:44:05 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/311faa0b84ffd110)
4 years, 3 months ago (2016-09-07 22:57:15 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320573005/40001
4 years, 3 months ago (2016-09-07 23:19:13 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 23:22:28 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/2a3e9913bec46d...

Powered by Google App Engine
This is Rietveld 408576698