Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2320573003: Issue 26874. Don't report CAN_BE_NULL_AFTER_NULL_AWARE for members of the Null class. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 26874. Don't report CAN_BE_NULL_AFTER_NULL_AWARE for members of the Null class. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/26874 Committed: https://github.com/dart-lang/sdk/commit/114fcdb839e2b0ba8902fb5422aa55fb02d74aec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -7 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 5 chunks +32 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-07 15:49:42 UTC) #1
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-09-07 15:54:28 UTC) #2
scheglov
4 years, 3 months ago (2016-09-07 16:01:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
114fcdb839e2b0ba8902fb5422aa55fb02d74aec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698