Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: chrome/renderer/autofill/password_generation_test_utils.cc

Issue 2320563002: [Password Generation] Use canonical version of action in for form matching in PasswordGenerationAgen (Closed)
Patch Set: Changes addressed to reviewer comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/autofill/password_generation_test_utils.h" 5 #include "chrome/renderer/autofill/password_generation_test_utils.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "components/autofill/content/renderer/form_autofill_util.h" 10 #include "components/autofill/content/renderer/form_autofill_util.h"
11 #include "components/autofill/content/renderer/test_password_generation_agent.h" 11 #include "components/autofill/content/renderer/test_password_generation_agent.h"
12 #include "components/autofill/core/common/password_form_generation_data.h" 12 #include "components/autofill/core/common/password_form_generation_data.h"
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 #include "third_party/WebKit/public/web/WebDocument.h" 14 #include "third_party/WebKit/public/web/WebDocument.h"
15 #include "third_party/WebKit/public/web/WebFormElement.h" 15 #include "third_party/WebKit/public/web/WebFormElement.h"
16 16
17 namespace autofill { 17 namespace autofill {
18 18
19 void SetNotBlacklistedMessage(TestPasswordGenerationAgent* generation_agent, 19 void SetNotBlacklistedMessage(TestPasswordGenerationAgent* generation_agent,
20 const char* form_str) { 20 const char* form_str) {
21 autofill::PasswordForm form; 21 autofill::PasswordForm form;
22 form.origin = 22 form.origin = form_util::StripAuthAndParams(
23 GURL(base::StringPrintf("data:text/html;charset=utf-8,%s", form_str)); 23 GURL(base::StringPrintf("data:text/html;charset=utf-8,%s", form_str)));
24 generation_agent->FormNotBlacklisted(form); 24 generation_agent->FormNotBlacklisted(form);
25 } 25 }
26 26
27 // Sends a message that the |form_index| form on the page is valid for 27 // Sends a message that the |form_index| form on the page is valid for
28 // account creation. 28 // account creation.
29 void SetAccountCreationFormsDetectedMessage( 29 void SetAccountCreationFormsDetectedMessage(
30 TestPasswordGenerationAgent* generation_agent, 30 TestPasswordGenerationAgent* generation_agent,
31 blink::WebDocument document, 31 blink::WebDocument document,
32 int form_index, 32 int form_index,
33 int field_index) { 33 int field_index) {
34 blink::WebVector<blink::WebFormElement> web_forms; 34 blink::WebVector<blink::WebFormElement> web_forms;
35 document.forms(web_forms); 35 document.forms(web_forms);
36 36
37 autofill::FormData form_data; 37 autofill::FormData form_data;
38 WebFormElementToFormData( 38 WebFormElementToFormData(
39 web_forms[form_index], blink::WebFormControlElement(), nullptr, 39 web_forms[form_index], blink::WebFormControlElement(), nullptr,
40 form_util::EXTRACT_NONE, &form_data, nullptr /* FormFieldData */); 40 form_util::EXTRACT_NONE, &form_data, nullptr /* FormFieldData */);
41 41
42 std::vector<autofill::PasswordFormGenerationData> forms; 42 std::vector<autofill::PasswordFormGenerationData> forms;
43 forms.push_back(autofill::PasswordFormGenerationData{ 43 forms.push_back(autofill::PasswordFormGenerationData{
44 form_data.name, form_data.action, form_data.fields[field_index]}); 44 form_data.name, form_data.action, form_data.fields[field_index]});
45 generation_agent->FoundFormsEligibleForGeneration(forms); 45 generation_agent->FoundFormsEligibleForGeneration(forms);
46 } 46 }
47 47
48 } // namespace autofill 48 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698