Revert of DevTools: Allow clicks to register in SSP when swatch popover is open

Revert of DevTools: Allow clicks to register in SSP when swatch popover is open (patchset #2 id:20001 of https://codereview.chromium.org/2307463004/ )

Reason for revert:
This breaks editing color swatches within shadow swatches. If you edit the color, and then edit the shadow, it reverts to the original color.

We should further examine the effects of majorChange=true in applyStyleText.

Original issue's description:
> DevTools: Allow clicks to register in SSP when swatch popover is open
>
> Applying the style text to the tree element when the popover is hidden
> causes the section to update, not allowing clicks to register.
>
> It is unnecessary to apply the style text when the popover is hidden
> (unless reverting back to original property text) because the change
> has already been applied.
>
> BUG=644779
>
> Committed: https://crrev.com/f8152e0a1d9157f873363a8b40951af0f6e0d6eb
> Cr-Commit-Position: refs/heads/master@{#417109}

TBR=lushnikov@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644779
Committed: https://crrev.com/d92a75f417b99a2abebb33234695eb60b96d04f1
Cr-Commit-Position: refs/heads/master@{#417140}

[flandy, 2016-09-08 01:01:01]

The CQ bit was checked by flandy@google.com

[flandy, 2016-09-08 01:01:01]

Created Revert of DevTools: Allow clicks to register in SSP when swatch popover
is open

[commit-bot: I haz the power, 2016-09-08 01:01:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 01:01:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 01:01:47]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[lushnikov, 2016-09-08 01:07:18]

rs lgtm

[lushnikov, 2016-09-08 01:07:23]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-09-08 01:07:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 01:10:58]

Description was changed from

==========
Revert of DevTools: Allow clicks to register in SSP when swatch popover is open
(patchset #2 id:20001 of https://codereview.chromium.org/2307463004/ )

Reason for revert:
This breaks editing color swatches within shadow swatches. If you edit the
color, and then edit the shadow, it reverts to the original color.

We should further examine the effects of majorChange=true in applyStyleText. 

Original issue's description:
> DevTools: Allow clicks to register in SSP when swatch popover is open
> 
> Applying the style text to the tree element when the popover is hidden
> causes the section to update, not allowing clicks to register.
> 
> It is unnecessary to apply the style text when the popover is hidden
> (unless reverting back to original property text) because the change
> has already been applied.
> 
> BUG=644779
> 
> Committed: https://crrev.com/f8152e0a1d9157f873363a8b40951af0f6e0d6eb
> Cr-Commit-Position: refs/heads/master@{#417109}

TBR=lushnikov@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644779
==========

to

==========
Revert of DevTools: Allow clicks to register in SSP when swatch popover is open
(patchset #2 id:20001 of https://codereview.chromium.org/2307463004/ )

Reason for revert:
This breaks editing color swatches within shadow swatches. If you edit the
color, and then edit the shadow, it reverts to the original color.

We should further examine the effects of majorChange=true in applyStyleText. 

Original issue's description:
> DevTools: Allow clicks to register in SSP when swatch popover is open
> 
> Applying the style text to the tree element when the popover is hidden
> causes the section to update, not allowing clicks to register.
> 
> It is unnecessary to apply the style text when the popover is hidden
> (unless reverting back to original property text) because the change
> has already been applied.
> 
> BUG=644779
> 
> Committed: https://crrev.com/f8152e0a1d9157f873363a8b40951af0f6e0d6eb
> Cr-Commit-Position: refs/heads/master@{#417109}

TBR=lushnikov@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644779
==========

[commit-bot: I haz the power, 2016-09-08 01:10:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-08 01:13:31]

Description was changed from

==========
Revert of DevTools: Allow clicks to register in SSP when swatch popover is open
(patchset #2 id:20001 of https://codereview.chromium.org/2307463004/ )

Reason for revert:
This breaks editing color swatches within shadow swatches. If you edit the
color, and then edit the shadow, it reverts to the original color.

We should further examine the effects of majorChange=true in applyStyleText. 

Original issue's description:
> DevTools: Allow clicks to register in SSP when swatch popover is open
> 
> Applying the style text to the tree element when the popover is hidden
> causes the section to update, not allowing clicks to register.
> 
> It is unnecessary to apply the style text when the popover is hidden
> (unless reverting back to original property text) because the change
> has already been applied.
> 
> BUG=644779
> 
> Committed: https://crrev.com/f8152e0a1d9157f873363a8b40951af0f6e0d6eb
> Cr-Commit-Position: refs/heads/master@{#417109}

TBR=lushnikov@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644779
==========

to

==========
Revert of DevTools: Allow clicks to register in SSP when swatch popover is open
(patchset #2 id:20001 of https://codereview.chromium.org/2307463004/ )

Reason for revert:
This breaks editing color swatches within shadow swatches. If you edit the
color, and then edit the shadow, it reverts to the original color.

We should further examine the effects of majorChange=true in applyStyleText.

Original issue's description:
> DevTools: Allow clicks to register in SSP when swatch popover is open
>
> Applying the style text to the tree element when the popover is hidden
> causes the section to update, not allowing clicks to register.
>
> It is unnecessary to apply the style text when the popover is hidden
> (unless reverting back to original property text) because the change
> has already been applied.
>
> BUG=644779
>
> Committed: https://crrev.com/f8152e0a1d9157f873363a8b40951af0f6e0d6eb
> Cr-Commit-Position: refs/heads/master@{#417109}

TBR=lushnikov@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644779

Committed: https://crrev.com/d92a75f417b99a2abebb33234695eb60b96d04f1
Cr-Commit-Position: refs/heads/master@{#417140}
==========

[commit-bot: I haz the power, 2016-09-08 01:13:32]

Patchset 1 (id:??) landed as
https://crrev.com/d92a75f417b99a2abebb33234695eb60b96d04f1
Cr-Commit-Position: refs/heads/master@{#417140}

[flandy, 2016-09-09 17:52:34]

https://codereview.chromium.org/2320533005/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js
(left):

https://codereview.chromium.org/2320533005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js:83:
if (!commitEdit)
For the record, this change should not be applied because majorChange=true in
applyStyleText is necessary since it marks the DOM undoable state so that undo
is handled correctly.