Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 2320533002: Restore a collapsed leading space of text used for line break (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 3 weeks ago by joone
Modified:
9 months, 3 weeks ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore a collapsed leading space of text used for line break When a text is wrapped during layout, the leading space of the text can be collapsed and a line break is inserted instead of the space. In this case, we need to restore the collapsed space when we copy the text. This CL can handle the following case: <div style="width: 2em;"><b><i>foo</i></b> bar</div> BUG=318925 TEST=editing/pasteboard/restore-collapsed-space-for-copy.html Committed: https://crrev.com/362b0c753edcf2e994de8ec82d9000f18e2ed284 Cr-Commit-Position: refs/heads/master@{#417155}

Patch Set 1 #

Patch Set 2 : Fix test fails #

Patch Set 3 : Make fast/text/output-isolate-at-end-of-line-crash.html pass #

Patch Set 4 : Refactoring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -46 lines) Patch
D third_party/WebKit/LayoutTests/editing/pasteboard/preserve-trailing-space.html View 1 chunk +0 lines, -41 lines 0 comments Download
A + third_party/WebKit/LayoutTests/editing/pasteboard/restore-collapsed-space-for-copy.html View 4 chunks +13 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 2 3 1 chunk +11 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 22 (17 generated)
joone
Hi yosin@ Please review this CL.
9 months, 3 weeks ago (2016-09-07 23:58:57 UTC) #16
yosin_UTC9
lgtm
9 months, 3 weeks ago (2016-09-08 01:38:02 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320533002/30004
9 months, 3 weeks ago (2016-09-08 01:38:30 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:30004)
9 months, 3 weeks ago (2016-09-08 01:43:05 UTC) #20
commit-bot: I haz the power
9 months, 3 weeks ago (2016-09-08 01:45:19 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/362b0c753edcf2e994de8ec82d9000f18e2ed284
Cr-Commit-Position: refs/heads/master@{#417155}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 23e94e589