Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: Source/core/loader/PingLoader.cpp

Issue 232053005: Implement navigator.sendBeacon() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Restructured ping loader code + added size restriction Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/PingLoader.cpp
diff --git a/Source/core/loader/PingLoader.cpp b/Source/core/loader/PingLoader.cpp
index 26894a1115d4b061d5586ca9be15003541907989..7fe3ec5df2a278910211ee3509ac0b23d328bfb0 100644
--- a/Source/core/loader/PingLoader.cpp
+++ b/Source/core/loader/PingLoader.cpp
@@ -43,7 +43,6 @@
#include "core/loader/UniqueIdentifier.h"
#include "core/page/Page.h"
#include "platform/exported/WrappedResourceRequest.h"
-#include "platform/network/FormData.h"
#include "platform/network/ResourceError.h"
#include "platform/network/ResourceRequest.h"
#include "platform/network/ResourceResponse.h"
@@ -54,6 +53,7 @@
#include "public/platform/WebURLResponse.h"
#include "wtf/OwnPtr.h"
+
abarth-chromium 2014/05/08 13:15:25 Extra blank line
namespace WebCore {
void PingLoader::loadImage(LocalFrame* frame, const KURL& url)
@@ -74,7 +74,7 @@ void PingLoader::loadImage(LocalFrame* frame, const KURL& url)
}
// http://www.whatwg.org/specs/web-apps/current-work/multipage/links.html#hyperlink-auditing
-void PingLoader::sendPing(LocalFrame* frame, const KURL& pingURL, const KURL& destinationURL)
+void PingLoader::sendLinkAuditPing(LocalFrame* frame, const KURL& pingURL, const KURL& destinationURL)
{
ResourceRequest request(pingURL);
request.setTargetType(ResourceRequest::TargetIsPing);
@@ -163,7 +163,7 @@ void PingLoader::didReceiveResponse(blink::WebURLLoader*, const blink::WebURLRes
delete this;
}
-void PingLoader::didReceiveData(blink::WebURLLoader*, const char* data, int dataLength, int encodedDataLength)
+void PingLoader::didReceiveData(blink::WebURLLoader*, const char*, int, int)
{
if (Page* page = this->page()) {
TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "ResourceFinish", "data", InspectorResourceFinishEvent::data(m_identifier, 0, true));

Powered by Google App Engine
This is Rietveld 408576698