public/web/WebFrameClient.h - Issue 232053005: Implement navigator.sendBeacon()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebFrameClient.h

Issue 232053005: Implement navigator.sendBeacon() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adjust unrelated test expectation Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: public/web/WebFrameClient.h

diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h

index cb32511719b8fb4286bcac9a7cfecf0e8557e2b7..d92481fad50d2e2d780a7819a62540d39f8d12da 100644

--- a/public/web/WebFrameClient.h

+++ b/public/web/WebFrameClient.h

@@ -320,7 +320,8 @@ public:

// A reflected XSS was encountered in the page and suppressed.

virtual void didDetectXSS(WebLocalFrame*, const WebURL&, bool didBlockEntirePage) { }

- // A PingLoader was created, and a request dispatched to a URL.

+ // A uni-directional loader (e.g., ping, beacon) was created, and a request dispatched to a URL.

+ // TODO: rename to didDispatchSimplexLoader()

virtual void didDispatchPingLoader(WebLocalFrame*, const WebURL&) { }

// The loaders in this frame have been stopped.