Avoid bogus type assertion on object comparison in Hydrogen

Avoid type assertion on object comparison in Hydrogen - the comparison is unreachable because of previous checks.

BUG=
R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20666

[Jarin, 2014-04-10 14:24:34]

Fixing another problem with the compare-object assertion in Hydrogen.

https://codereview.chromium.org/232053004/diff/1/src/hydrogen.cc
File src/hydrogen.cc (left):

https://codereview.chromium.org/232053004/diff/1/src/hydrogen.cc#oldcode9878
src/hydrogen.cc:9878: }
I have removed this because it does not use HCompareObjectEqAndBranch, so we do
not run into problems with the assertion. The bad case should be rare, so
bailing out early is not worth the added complexity here.

[Yang, 2014-04-10 14:59:05]

On 2014/04/10 14:24:34, jarin wrote:
> Fixing another problem with the compare-object assertion in Hydrogen.
> 
> https://codereview.chromium.org/232053004/diff/1/src/hydrogen.cc
> File src/hydrogen.cc (left):
> 
> https://codereview.chromium.org/232053004/diff/1/src/hydrogen.cc#oldcode9878
> src/hydrogen.cc:9878: }
> I have removed this because it does not use HCompareObjectEqAndBranch, so we
do
> not run into problems with the assertion. The bad case should be rare, so
> bailing out early is not worth the added complexity here.

lgtm.

[Jarin, 2014-04-11 06:45:32]

Committed patchset #1 manually as r20666 (presubmit successful).