 Chromium Code Reviews
 Chromium Code Reviews Issue 232053002:
  Android: Fix default filename for kTraceStartup file  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 232053002:
  Android: Fix default filename for kTraceStartup file  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: content/browser/browser_main_loop.cc | 
| diff --git a/content/browser/browser_main_loop.cc b/content/browser/browser_main_loop.cc | 
| index 2a6b823c2e9c7ff5ab5e34fa74d6d04f1b097896..5a7c5b90e880248be1875fd93ce1cf41876df697 100644 | 
| --- a/content/browser/browser_main_loop.cc | 
| +++ b/content/browser/browser_main_loop.cc | 
| @@ -70,6 +70,7 @@ | 
| #include "base/android/jni_android.h" | 
| #include "content/browser/android/browser_startup_controller.h" | 
| #include "content/browser/android/surface_texture_peer_browser_impl.h" | 
| +#include "content/browser/android/tracing_controller_android.h" | 
| #include "ui/gl/gl_surface.h" | 
| #endif | 
| @@ -253,6 +254,10 @@ static void SetUpGLibLogHandler() { | 
| } | 
| #endif | 
| +void OnStoppedStartupTracing(const base::FilePath& trace_file) { | 
| + LOG(INFO) << "Completed startup tracing to " << trace_file.value(); | 
| 
piman
2014/04/11 07:45:20
Hmm, I'm getting presubmit issues in a patch that
 | 
| +} | 
| + | 
| } // namespace | 
| // The currently-running BrowserMainLoop. There can be one or zero. | 
| @@ -1095,8 +1100,12 @@ void BrowserMainLoop::InitStartupTracing(const CommandLine& command_line) { | 
| return; | 
| if (trace_file.empty()) { | 
| +#if defined(OS_ANDROID) | 
| + TracingControllerAndroid::GenerateTracingFilePath(&trace_file); | 
| +#else | 
| // Default to saving the startup trace into the current dir. | 
| trace_file = base::FilePath().AppendASCII("chrometrace.log"); | 
| +#endif | 
| } | 
| std::string delay_str = command_line.GetSwitchValueASCII( | 
| @@ -1118,7 +1127,7 @@ void BrowserMainLoop::InitStartupTracing(const CommandLine& command_line) { | 
| void BrowserMainLoop::EndStartupTracing(const base::FilePath& trace_file) { | 
| is_tracing_startup_ = false; | 
| TracingController::GetInstance()->DisableRecording( | 
| - trace_file, TracingController::TracingFileResultCallback()); | 
| + trace_file, base::Bind(&OnStoppedStartupTracing)); | 
| } | 
| } // namespace content |