Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 23205014: Introduce toSVGLinearGradientElement(), and use it (Closed)

Created:
7 years, 4 months ago by gyuyoung-inactive
Modified:
7 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce toSVGLinearGradientElement(), and use it As a step to clean-up static_cast<SVGXXX>, toSVGLinearGradientElement() is added to clean-up static_cast<SVGLinearGradientElement*>. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M Source/core/rendering/svg/RenderSVGResourceLinearGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.h View 2 chunks +7 lines, -0 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
gyuyoung-inactive
tkent, please take a look this patch.
7 years, 4 months ago (2013-08-20 11:54:16 UTC) #1
tkent
lgtm
7 years, 4 months ago (2013-08-20 23:29:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23205014/1
7 years, 4 months ago (2013-08-20 23:29:23 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-21 03:32:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23205014/1
7 years, 4 months ago (2013-08-21 03:33:17 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 05:55:16 UTC) #6
Message was sent while issue was closed.
Change committed as 156442

Powered by Google App Engine
This is Rietveld 408576698