Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2320473004: test.dart: Print stack traces of all threads when a test times out (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 132d0c6d7f3d6ffc5d84b467a290b11ff8dcbc9d..0f55b0ad154ec116357302bfb856e28bf1958a22 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -1854,9 +1854,19 @@ class RunningProcess {
void timeoutHandler() {
timedOut = true;
if (process != null) {
- if (!process.kill()) {
- DebugLogger.error("Unable to kill ${process.pid}");
- }
+ io.Process.run('gdb',
rmacnak 2016/09/07 19:33:47 Only attempt to use gdb on Linux.
Florian Schneider 2016/09/07 21:02:58 Done.
+ ['--pid=${process.pid}',
+ '--eval-command=thread apply all bt',
+ '--eval-command=quit'])
+ .then((result) {
+ io.stdout.write(result.stdout);
+ io.stderr.write(result.stderr);
+ })
siva 2016/09/07 19:55:20 Do we also need a catchError handler here to print
Florian Schneider 2016/09/07 21:02:58 Yes. Added printing. Also, I should only invoke gd
Bill Hesse 2016/09/08 14:58:01 I would just run "which gdb" in a subprocess, and
+ .whenComplete(() {
+ if (!process.kill()) {
+ DebugLogger.error("Unable to kill ${process.pid}");
+ }
+ });
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698