third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp - Issue 2320463002: [SPV2] Implement the blink-side scroll property tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

Issue 2320463002: [SPV2] Implement the blink-side scroll property tree (Closed)

Patch Set: Prevent circular reference caught by lsan Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

index 615790ee60e6acf14385a85f10807f5a290109b5..a1a493238496563a5b21b733addac70822d5eefc 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

@@ -333,6 +333,7 @@ PaintLayerPainter::PaintResult PaintLayerPainter::paintLayerContents(GraphicsCon

PaintChunkProperties properties(context.getPaintController().currentPaintChunkProperties());

auto& localBorderBoxProperties = *objectPaintProperties->localBorderBoxProperties();

properties.transform = localBorderBoxProperties.propertyTreeState.transform;

+ properties.scroll = localBorderBoxProperties.scroll;

properties.clip = localBorderBoxProperties.propertyTreeState.clip;

properties.effect = localBorderBoxProperties.propertyTreeState.effect;

properties.backfaceHidden = m_paintLayer.layoutObject()->hasHiddenBackface();