Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2240)

Unified Diff: chrome/browser/resources/PRESUBMIT.py

Issue 2320443002: Disable adding closure_compilation bots post-upload, they're all broken (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/webui/resources/PRESUBMIT.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/PRESUBMIT.py
diff --git a/chrome/browser/resources/PRESUBMIT.py b/chrome/browser/resources/PRESUBMIT.py
index 9dac91943826e66a0467667a4b2ac99ba5e8b82b..1dbbe75cd2885ddb249afe4ac7e514c14464da50 100644
--- a/chrome/browser/resources/PRESUBMIT.py
+++ b/chrome/browser/resources/PRESUBMIT.py
@@ -99,25 +99,25 @@ def CheckChangeOnCommit(input_api, output_api):
return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH)
-def PostUploadHook(cl, change, output_api):
- rietveld_obj = cl.RpcServer()
- description = rietveld_obj.get_description(cl.issue)
-
- existing_bots = (change.CQ_INCLUDE_TRYBOTS or '').split(';')
- clean_bots = set(filter(None, map(lambda s: s.strip(), existing_bots)))
- new_bots = clean_bots | set(
- ['master.tryserver.chromium.linux:closure_compilation'])
- new_tag = 'CQ_INCLUDE_TRYBOTS=%s' % ';'.join(new_bots)
-
- if clean_bots:
- tag_reg = '^CQ_INCLUDE_TRYBOTS=.*$'
- new_description = re.sub(tag_reg, new_tag, description, flags=re.M | re.I)
- else:
- new_description = description + '\n' + new_tag
-
- if new_description == description:
- return []
-
- rietveld_obj.update_description(cl.issue, new_description)
- return [output_api.PresubmitNotifyResult(
- 'Automatically added optional Closure bots to run on CQ.')]
+# def PostUploadHook(cl, change, output_api):
+# rietveld_obj = cl.RpcServer()
+# description = rietveld_obj.get_description(cl.issue)
+#
+# existing_bots = (change.CQ_INCLUDE_TRYBOTS or '').split(';')
+# clean_bots = set(filter(None, map(lambda s: s.strip(), existing_bots)))
+# new_bots = clean_bots | set(
+# ['master.tryserver.chromium.linux:closure_compilation'])
+# new_tag = 'CQ_INCLUDE_TRYBOTS=%s' % ';'.join(new_bots)
+#
+# if clean_bots:
+# tag_reg = '^CQ_INCLUDE_TRYBOTS=.*$'
+# new_description = re.sub(tag_reg, new_tag, description, flags=re.M | re.I)
+# else:
+# new_description = description + '\n' + new_tag
+#
+# if new_description == description:
+# return []
+#
+# rietveld_obj.update_description(cl.issue, new_description)
+# return [output_api.PresubmitNotifyResult(
+# 'Automatically added optional Closure bots to run on CQ.')]
« no previous file with comments | « no previous file | ui/webui/resources/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698