Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: chrome/browser/resources/PRESUBMIT.py

Issue 2320443002: Disable adding closure_compilation bots post-upload, they're all broken (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/webui/resources/PRESUBMIT.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for files in chrome/browser/resources. 5 """Presubmit script for files in chrome/browser/resources.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 92
93 93
94 def CheckChangeOnUpload(input_api, output_api): 94 def CheckChangeOnUpload(input_api, output_api):
95 return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH) 95 return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH)
96 96
97 97
98 def CheckChangeOnCommit(input_api, output_api): 98 def CheckChangeOnCommit(input_api, output_api):
99 return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH) 99 return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH)
100 100
101 101
102 def PostUploadHook(cl, change, output_api): 102 # def PostUploadHook(cl, change, output_api):
103 rietveld_obj = cl.RpcServer() 103 # rietveld_obj = cl.RpcServer()
104 description = rietveld_obj.get_description(cl.issue) 104 # description = rietveld_obj.get_description(cl.issue)
105 105 #
106 existing_bots = (change.CQ_INCLUDE_TRYBOTS or '').split(';') 106 # existing_bots = (change.CQ_INCLUDE_TRYBOTS or '').split(';')
107 clean_bots = set(filter(None, map(lambda s: s.strip(), existing_bots))) 107 # clean_bots = set(filter(None, map(lambda s: s.strip(), existing_bots)))
108 new_bots = clean_bots | set( 108 # new_bots = clean_bots | set(
109 ['master.tryserver.chromium.linux:closure_compilation']) 109 # ['master.tryserver.chromium.linux:closure_compilation'])
110 new_tag = 'CQ_INCLUDE_TRYBOTS=%s' % ';'.join(new_bots) 110 # new_tag = 'CQ_INCLUDE_TRYBOTS=%s' % ';'.join(new_bots)
111 111 #
112 if clean_bots: 112 # if clean_bots:
113 tag_reg = '^CQ_INCLUDE_TRYBOTS=.*$' 113 # tag_reg = '^CQ_INCLUDE_TRYBOTS=.*$'
114 new_description = re.sub(tag_reg, new_tag, description, flags=re.M | re.I) 114 # new_description = re.sub(tag_reg, new_tag, description, flags=re.M | re.I)
115 else: 115 # else:
116 new_description = description + '\n' + new_tag 116 # new_description = description + '\n' + new_tag
117 117 #
118 if new_description == description: 118 # if new_description == description:
119 return [] 119 # return []
120 120 #
121 rietveld_obj.update_description(cl.issue, new_description) 121 # rietveld_obj.update_description(cl.issue, new_description)
122 return [output_api.PresubmitNotifyResult( 122 # return [output_api.PresubmitNotifyResult(
123 'Automatically added optional Closure bots to run on CQ.')] 123 # 'Automatically added optional Closure bots to run on CQ.')]
OLDNEW
« no previous file with comments | « no previous file | ui/webui/resources/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698