Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2320423002: NTPSnippets: User locale was not set when user isn't signed in. (Closed)

Created:
4 years, 3 months ago by finkm
Modified:
4 years, 3 months ago
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTPSnippets: User locale was not set when user isn't signed in. BUG=645425 Committed: https://crrev.com/ead96b7ebf2c7a910a8ffdb95ec85df70235775e Cr-Commit-Position: refs/heads/master@{#417592}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/ntp_snippets/ntp_snippets_fetcher.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
finkm
PTAL
4 years, 3 months ago (2016-09-09 11:33:32 UTC) #3
finkm
@bauerb: treib is OOO. Can you PTAL?
4 years, 3 months ago (2016-09-09 12:22:03 UTC) #5
Bernhard Bauer
lgtm
4 years, 3 months ago (2016-09-09 14:44:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320423002/1
4 years, 3 months ago (2016-09-09 14:49:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 15:55:44 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 15:57:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ead96b7ebf2c7a910a8ffdb95ec85df70235775e
Cr-Commit-Position: refs/heads/master@{#417592}

Powered by Google App Engine
This is Rietveld 408576698